Opened 8 years ago

Closed 7 years ago

#4978 closed defect (wontfix)

I found a small bug in TorCtl.py, in connection.map_address()

Reported by: derpington Owned by:
Priority: Medium Milestone:
Component: Torctl Version: Tor: unspecified
Severity: Keywords: mapaddress
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In method connection.map_address() in TorCtl.py, the following line is supposed to build the line to be sent to the tor control port in order to map a list of adresses:

m = " ".join([ "%s=%s" for k,v in kvList])

The string "%s=%s" lacks formatting. Better:

m = " ".join([ "%s=%s" (k,v) for (k,v) in kvList])

My first contrib to open source (:
I hope this is the right place for this

Child Tickets

Change History (1)

comment:1 Changed 7 years ago by atagar

Resolution: wontfix
Status: newclosed

This doesn't seem to be disrupting the BW auths so resolving.

https://blog.torproject.org/blog/torctl-deprecation-and-stem-plans

Note: See TracTickets for help on using tickets.