MyFamily as a list

Hi,

MyFamily currently is a config string. It'd be nice if it was a line list like RecommendedVersions as that would make configuration files a bit more readable.

changed milestone to %Tor: 0.3.1.x-final

added component::core tor/tor easy intro lorax milestone::Tor: 0.3.1.x-final owner::Jigsaw52 parent::15060 priority::medium resolution::implemented severity::normal status::closed tor-relay type::defect version::tor 0.2.3.11-alpha labels

Sounds like a plausible idea to me. It would need to be a listlist of comma-separated entries, for backward compatibility.

Trac:
Milestone: N/A to Tor: unspecified

Trac:
Keywords: N/A deleted, tor-relay added

Trac:
Component: Tor Relay to Tor

Trac:
Parent: N/A to #15060 (moved)

Trac:
Sponsor: N/A to N/A
Keywords: tor-relay deleted, tor-relay lorax added

Trac:
Keywords: tor-relay lorax deleted, tor-relay lorax easy intro added
Severity: N/A to Normal

Trac:
Username: pingl

config.patch

config.c patch

Trac:
Username: pingl

Trac:
Reviewer: N/A to N/A
Status: new to needs_review

The code that processes MyFamily still expects it to be a char * - this patch changes it to a smartlist * containing char *, but doesn't change how it's processed.

Trac:
Status: needs_review to needs_revision

I tried to fix this on this branch: https://github.com/Jigsaw52/tor/tree/my-family-list-fix-4498

Trac:
Status: needs_revision to needs_review

Trac:
Milestone: Tor: unspecified to Tor: 0.3.1.x-final

Getting there!

But it looks like this patch makes it so Tor would no longer accept the old format. That's not right, though: we need to make sure that the there can be multiple lines and multiple options on each line. Otherwise all old MyFamily lines will stop working.

Trac:
Status: needs_review to needs_revision

I does accept both multiple lines and multiple options on the same line. I have changed the test to actually test both cases and tested manually with the following lines on torrc:

MyFamily $1111111111111111111111111111111111111111, 1111111111111111111111111111111111111112, $1111111111111111111111111111111111111113
MyFamily 1111111111111111111111111111111111111114
MyFamily $1111111111111111111111111111111111111115

However, I did change the man page to mention only the new format. I did that to encourage the use of the new format. I can change the man page to mention both formats if you think it is better.

Trac:
Status: needs_revision to needs_review

Trac:
Owner: N/A to Jigsaw52
Status: needs_review to assigned

Trac:
Status: assigned to needs_review

Oh, I see what you did. Yes, you're correct there. The code looks like it should work.

One thing that we try not to do any more, though: we try not to rewrite values that could get written back into the torrc by a SAVECONF command. What we usually do instead now is, when we want to normalize a configuration value, normalize it into a separate field of or_options_t. What do you think of the patch I've made on top of your branch, in my-family-list-fix-4498 in my public repository? The URL is

https://gitweb.torproject.org/nickm/tor.git/log/?h=my-family-list-fix-4498

Trac:
Status: needs_review to merge_ready

Thanks for the explanation. I checked out out your branch and tested it and everything seems fine.

Excellent; merged to master. Thanks for the patches!

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

Alas, this patch seems to have caused #22368 (moved) (a double free bug).

closed

mentioned in issue #22368 (moved)

moved to tpo/core/tor#4998 (closed)