Opened 8 years ago

Closed 8 years ago

#5036 closed enhancement (fixed)

Google "sorry" captcha now supports HTTPS

Reported by: ugh Owned by: pde
Priority: Medium Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Good news! It is now possible to do the Google captcha over HTTPS, but only through https://sorry.google.com/sorry/...

If you try instead https://www.google.com/sorry/... it will just redirect you to the Google homepage right away.

Another issue is that the "continue" GET variable, which holds the URL for redirection, will default to HTTP even if the original search was through HTTPS, so it will have to be rewritten, too.

I tried the following (rough) ruleset as a proof of concept, but for some reason it doesn't seem to do anything here (which may be a problem with my installation):

<ruleset name="GoogleSorry">
  <target host="www.google.com" />

  <rule from="^http://www\.google\.com/sorry/\?continue=http" to="https://sorry.google.com/sorry/\?continue=https" />
</ruleset>

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by ugh

Type: defectenhancement

comment:2 Changed 8 years ago by ugh

Here's a working and more comprehensive ruleset:

<ruleset name="GoogleSorry">
  <target host="www.google.com" />
  <target host="sorry.google.com" />
  <target host="google.com" />

  <rule from="^https?://((sorry|www)\.)?google\.com/sorry/(Captcha)?\?continue=http([^s])" to="https://sorry.google.com/sorry/?continue=https$4" />
</ruleset>

comment:3 Changed 8 years ago by ugh

It just occured to me that the "continue" variable can in fact be ignored, and should be, because HTTPS Everywhere will properly take care of the subsequent request. So:

<ruleset name="GoogleSorry">
  <target host="sorry.google.com" />
  <target host="www.google.com" />
  <target host="google.com" />

  <rule from="^http://((sorry|www)\.)?google\.com/sorry/" to="https://sorry.google.com/sorry/" />
</ruleset>

comment:4 Changed 8 years ago by pde

https://gitweb.torproject.org/https-everywhere.git/commitdiff/8d5578088eccd69f582f6e51c426333347717039

comment:5 Changed 8 years ago by pde

Resolution: fixed
Status: newclosed

This has shipped in the development branch.

Note: See TracTickets for help on using tickets.