Opened 8 years ago

Closed 6 years ago

#5064 closed defect (fixed)

wrong image width/height values in html code

Reported by: skep Owned by: phobos
Priority: Medium Milestone:
Component: Webpages/Website Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi,

in the new obfsproxy page at:
https://www.torproject.org/projects/obfsproxy-instructions.html.en

the image html values for width & height of the console image (obfs-spwn_tor_bridge.png) are wrong and thefore the content is hard to read. It should be:

<img src="../images/obfs-spawn_tor_bridge.png" alt="spawn tor" height="117" width="879">

Child Tickets

Attachments (2)

obfs-spawn_tor_bridge.png (37.4 KB) - added by jmtodaro 7 years ago.
Here's a resized obfs-spawn_tor_bridge.png for consideration. The filesize is a bit beefier than the original (~9k to ~35k), but this was necessary to keep the text as legible as possible.
5064.diff (466 bytes) - added by jmtodaro 7 years ago.
I just realized that you'll need this patch to obfsproxy-instructions.wml too. It just removes the incorrect image size overrides.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by phobos

Resolution: fixed
Status: newclosed

fixed and deployed.

comment:2 Changed 8 years ago by skep

Resolution: fixed
Status: closedreopened

Hi, well, the img html tag now has the right dimensions, but the overall css definition overrules it, by setting a max-width of 710px for the img tag and therefore the image is still distorted. Maybe its better to resize all images that have a width > 710px to 710px.

comment:3 Changed 8 years ago by phobos

patches to wml and css are welcome, otherwise I don't see this getting fixed.

comment:4 Changed 8 years ago by Sebastian

In this specific case, the max width is enforced but the resulting image doesn't look bad anymore, does it? At least it doesn't for me in the (small) range of browsers I have available. If we forced the true size of the image here, we'd blow up the general design? What kind of solution are you thinking of, skep?

Changed 7 years ago by jmtodaro

Attachment: obfs-spawn_tor_bridge.png added

Here's a resized obfs-spawn_tor_bridge.png for consideration. The filesize is a bit beefier than the original (~9k to ~35k), but this was necessary to keep the text as legible as possible.

Changed 7 years ago by jmtodaro

Attachment: 5064.diff added

I just realized that you'll need this patch to obfsproxy-instructions.wml too. It just removes the incorrect image size overrides.

comment:5 Changed 7 years ago by phobos

look good, apparently already applied

comment:6 Changed 6 years ago by phobos

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.