Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#5065 closed defect (fixed)

Executable paths for shasum/openssl not protected against whitespace

Reported by: Sebastian Owned by:
Priority: High Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

in Makefile.am, we use @OPENSSL@ without properly quoting it. This is breaking the build on Windows for my build system

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by Sebastian

Status: newneeds_review

branch bug5065 in my repository. Also contains a check-spaces cleanup patch.

comment:2 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.2.x-final
Status: needs_reviewneeds_revision

Looks good, but shouldn't this be on 0.2.2?

comment:3 Changed 8 years ago by Sebastian

It is, afaict, not a problem when you build from a tarball; so I thought maybe we don't need it on 0.2.2. Also the forward merge does have conflicts. I prepared a branch bug5065_022, so you can decide which you'd rather use. If you go with bug5065_022, please cherry-pick the checkspaces thing from my bug5065 branch.

comment:4 Changed 8 years ago by arma

Status: needs_revisionneeds_review

Looks good. I'll let Nick decide whether it should go into 0.2.2 or master. My tendency is to agree with him that it should go into 0.2.2 also.

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged into 0.2.2 and master. Cherry-picked the checkspaces thing. Thanks!

comment:6 Changed 7 years ago by nickm

Keywords: tor-client added

comment:7 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.