#5065 closed defect (fixed)
Executable paths for shasum/openssl not protected against whitespace
| Reported by: | Sebastian | Owned by: | |
|---|---|---|---|
| Priority: | High | Milestone: | Tor: 0.2.2.x-final |
| Component: | Core Tor/Tor | Version: | |
| Severity: | Keywords: | tor-client | |
| Cc: | Actual Points: | ||
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
in Makefile.am, we use @OPENSSL@ without properly quoting it. This is breaking the build on Windows for my build system
Child Tickets
Change History (7)
comment:1 Changed 8 years ago by
| Status: | new → needs_review |
|---|
comment:2 Changed 8 years ago by
| Milestone: | Tor: 0.2.3.x-final → Tor: 0.2.2.x-final |
|---|---|
| Status: | needs_review → needs_revision |
Looks good, but shouldn't this be on 0.2.2?
comment:3 Changed 8 years ago by
It is, afaict, not a problem when you build from a tarball; so I thought maybe we don't need it on 0.2.2. Also the forward merge does have conflicts. I prepared a branch bug5065_022, so you can decide which you'd rather use. If you go with bug5065_022, please cherry-pick the checkspaces thing from my bug5065 branch.
comment:4 Changed 8 years ago by
| Status: | needs_revision → needs_review |
|---|
Looks good. I'll let Nick decide whether it should go into 0.2.2 or master. My tendency is to agree with him that it should go into 0.2.2 also.
comment:5 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | needs_review → closed |
Merged into 0.2.2 and master. Cherry-picked the checkspaces thing. Thanks!
comment:6 Changed 8 years ago by
| Keywords: | tor-client added |
|---|
comment:7 Changed 8 years ago by
| Component: | Tor Client → Tor |
|---|
Note: See
TracTickets for help on using
tickets.
branch bug5065 in my repository. Also contains a check-spaces cleanup patch.