Opened 7 years ago

Closed 6 years ago

#5077 closed defect (wontfix)

obfsproxy configure: error: could not find ntohl

Reported by: arma Owned by: asn
Priority: Medium Milestone:
Component: Obfuscation/Obfsproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

obfsproxy autoconf has a weird habit of putting file names on the build line of test programs. For example, if you incorrectly set libevent_LIBS="/usr/local/lib" (without the -L) then autoconf will just plunk that down onto the build line of its program that tests whether ntohl works. The test program won't build ("why did you say /usr/local/lib on my command line"), so autoconf concludes there's no ntohl.

People seem to report the "could not find ntohl" for all sorts of reasons, each of which boil down to some other thing in their build environment going wrong, and the ntohl test being the first one in autoconf's list.

Child Tickets

Attachments (1)

yj5DfhUg.txt (862 bytes) - added by asn 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by asn

Status: newneeds_review

Attached patch by 'rsavoye'.

Changed 7 years ago by asn

Attachment: yj5DfhUg.txt added

comment:2 Changed 7 years ago by asn

Status: needs_reviewnew

Oops, it seems like I misunderstood rsavoye.

The attached patch tries to simplify our autotools logic, by rendering (the potentially broken) winsock.m4 useless.

The attached patch does not fix this bug.

comment:3 Changed 7 years ago by rsavoye

For this patch to fully work, you also need to remove @ws32_LIBS@ from LDADD= in Makefile.am. This substitution variable was set in winsock2.m4, so produces a compile time error as it's now not set.

comment:4 Changed 7 years ago by asn

Status: newneeds_review

note to self: rsavoye told me that I can find his work on this ticket in branch 5077 in git@github.com:rsavoye/obfsproxy.git.

comment:5 Changed 7 years ago by asn

It seems that this ticket is hosting two different issues:

a) The fact that ntohl is the first test we are doing and uses our CFLAGS. Which means that if our CFLAGS are b0rked, we get "ntohl could not be found" and not "your CFLAGS are b0rked".

b) The fact that the current ntohl test in m4/winsock.m4 is overengineered and can be replacaed by AC_TRY_LINK.

All the patches and branches referenced in previous comments are addressing b). I created #5675 for b).

Let's keep this ticket for a).

comment:6 Changed 6 years ago by asn

Resolution: wontfix
Status: needs_reviewclosed

This ticket is about the old C-based obfsproxy. Closing.

Note: See TracTickets for help on using tickets.