Opened 7 years ago

Closed 7 years ago

Last modified 18 months ago

#5097 closed defect (fixed)

“TOR_PT_EXTENDED_SERVER_PORT=127.0.0.1:4200”

Reported by: rransom Owned by:
Priority: Immediate Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-bridge
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor puts “TOR_PT_EXTENDED_SERVER_PORT=127.0.0.1:4200” in the environment of every managed proxy it starts, because proposal 180 ‘requires’ that Tor pass that environment variable. Even if we keep that ‘required’ in the spec, we would be better off leaving that environment variable out than filling it with a plausible but utterly bullshit value like that.

Child Tickets

Change History (9)

comment:1 Changed 7 years ago by Sebastian

Seems like this is a three-fold effort. We need to patch the spec, Tor, and obfsproxy. The spec because it doesn't make sense currently, Tor because it writes insanity to the env, and obfsproxy because it asserts that some kind of insanity exists, even tho it's not going to use it at all currently.

comment:2 Changed 7 years ago by Sebastian

branch prop180_extended_orport in my torspec repo for the proposal patch

comment:3 Changed 7 years ago by Sebastian

branch bug5097 in my obfsproxy repository

comment:4 Changed 7 years ago by Sebastian

Status: newneeds_review

branch bug5097 in rransom's tor repository

comment:5 in reply to:  4 Changed 7 years ago by rransom

Replying to Sebastian:

branch bug5097 in rransom's tor repository

I've pushed another commit, because I missed the Windows version of that function the first time.

comment:6 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Seriouly, git commit messages like "Fix #5097" are not what we do.

Fixed the commit message and merged.

comment:7 Changed 7 years ago by nickm

Keywords: tor-bridge added

comment:8 Changed 7 years ago by nickm

Component: Tor BridgeTor

comment:9 Changed 18 months ago by teor

Severity: Normal

Set all tickets without a severity to "Normal"

Note: See TracTickets for help on using tickets.