Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5099 closed defect (fixed)

When ServerTransportPlugin specifies a non-existent file, there's only a debug log

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Instead we should warn the user about it. This is a very easy to make mistake, and the error messages that follow don't make sense.

The debug message you'd have to parse is:

[Debug] handle_proxy_line(): Got a line from managed proxy: ERR: Failed to spawn background process - code 9/2

Child Tickets

Change History (8)

comment:1 Changed 8 years ago by asn

Status: newneeds_information

Are you sure?

When I specify a non-existent file (like /usr/locala/bin/obfsproxy or /usr/local/bin/obfsproxyy), I'm getting:

[warn] Could not launch managed proxy executable!

comment:2 in reply to:  1 Changed 8 years ago by rransom

Replying to asn:

Are you sure?

When I specify a non-existent file (like /usr/locala/bin/obfsproxy or /usr/local/bin/obfsproxyy), I'm getting:

[warn] Could not launch managed proxy executable!

That message does not specify the filename or the error that occurred while trying to launch the managed proxy. It is not useful.

comment:3 Changed 7 years ago by asn

To get the necessary information here we must first fix #5557, so that we can properly parse the error message like log_from_pipe() does.

comment:4 Changed 7 years ago by asn

Status: needs_informationnew

comment:5 Changed 7 years ago by asn

Status: newneeds_review

Please see branch bug5099 in https://git.gitorious.org/mytor/mytor.git.

comment:6 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks like a clear win to me. I'm going to call it a bugfix, add a "bugfix on XYZ" to the changes message, and cherry-pick it to maint-0.2.3. (It looks like you did it based on master, which is now 0.2.4.)

comment:7 Changed 7 years ago by nickm

Keywords: tor-client added

comment:8 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.