Opened 8 years ago

Closed 7 years ago

#5107 closed defect (fixed)

Usability problem: if you add a bridge and click ok, but didn't click +, you don't add the bridge

Reported by: arma Owned by: chiiph
Priority: Medium Milestone:
Component: Archived/Vidalia Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Go to settings->network, have some bridges already, paste a new onto the bridge text box, then click ok. You don't end up using the bridge.

This is related to #4290, but is even more subtle since if your other bridges work you'll never even notice you didn't add this one.

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by arma

Maybe the right fix is for the 'ok' button to notice that there's text in the bridge text box, and automatically do the equivalent of clicking + for it? Are there any downsides to that approach?

That would probably also be a better fix for mikeperry's bug in #4290 than git commit e46a569dd, since it would do-what-he-meant rather than tell-him-it-didn't-do-what-he-meant.

comment:2 in reply to:  1 Changed 8 years ago by chiiph

Replying to arma:

Maybe the right fix is for the 'ok' button to notice that there's text in the bridge text box, and automatically do the equivalent of clicking + for it? Are there any downsides to that approach?

Sounds good, the only thing that I would add is a message to the user saying "You meant to add this bridge but didn't click the plus button. Do you want Vidalia to do it for you? <checkbox> Remember this answer". I generally don't like silently assuming things, Vidalia's behavior has been like this for years, so there are may be users aware of this and may be use this somehow.

That would probably also be a better fix for mikeperry's bug in #4290 than git commit e46a569dd, since it would do-what-he-meant rather than tell-him-it-didn't-do-what-he-meant.

Right, so, right now, Go to settings->network, have some bridges already, paste a new onto the bridge text box, then click ok. Vidalia shows a popup saying that you're missing a bridge, which either leads you to click the plus button, or just leaves you without a clue why that bridge isn't added. If you uncheck the usebridge *then* you don't end up using the bridge.
So it's not a direct way to failure, but I understand it's not the best way to go. I think a label above the lineedit saying "Bridge to add", and another one above the bridge list saying "Bridge list" will make it more clear that the user needs to make the text in "Bridge to add" go to "Bridge list" somehow.

comment:3 Changed 7 years ago by chiiph

Resolution: fixed
Status: newclosed

This has been fixed in my branch chiiph/5107_addbridge. The bridge is automatically added if it's still in the lineedit when the user presses Ok.

The fix will be out with 0.3.3-alpha.

Note: See TracTickets for help on using tickets.