Opened 8 years ago

Closed 8 years ago

#5110 closed defect (fixed)

Languages should name themselves in their own language

Reported by: arma Owned by: chiiph
Priority: Medium Milestone:
Component: Archived/Vidalia Version: Vidalia: 0.2.17
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Vidalia 0.2.17 supports Korean (great), but in the language drop-down box it calls it Korean. It should instead call itself 한국어.

This is probably the case for some of the other new languages too.

Child Tickets

Change History (10)

comment:1 Changed 8 years ago by chiiph

Agreed, but did you just put "Korean" in google translate? I'm not sure how to actually "debug" the result of something like that.

comment:2 in reply to:  1 Changed 8 years ago by arma

Replying to chiiph:

Agreed, but did you just put "Korean" in google translate? I'm not sure how to actually "debug" the result of something like that.

No, I stole it from the bottom of www.debian.org again.

"한국어"

I'm not sure what the character set Vidalia uses in its code is, or how to map them, though.

comment:4 Changed 8 years ago by arma

Similarly, Catalan wants to be 'català', Greek wants to be 'Ελληνικά', we probably want to move suomi so it's right above svenska, and Indonesian wants to be 'Indonesia'.

comment:5 in reply to:  4 ; Changed 8 years ago by rransom

Replying to arma:

Similarly, Catalan wants to be 'català', Greek wants to be 'Ελληνικά', we probably want to move suomi so it's right above svenska,

Where do “suomi” and “svenska” sort in their languages' collating sequences?

and Indonesian wants to be 'Indonesia'.

Not “bahasa Indonesia”?

comment:6 in reply to:  5 Changed 8 years ago by arma

Replying to rransom:

Where do “suomi” and “svenska” sort in their languages' collating sequences?

[...]

Not “bahasa Indonesia”?

In both cases I'm following www.debian.org's lead. They seem to have done their homework in other cases.

comment:7 Changed 8 years ago by feroze

Status: newneeds_review

I have added the utf-8 code for Korean as given in debian.org

https://github.com/feroze/vidalia/commit/2374209fa0779b6d057134088a6ac194264e7338

comment:8 Changed 8 years ago by chiiph

Status: needs_reviewneeds_revision

Feroze: are you planning on doing that for the rest of the languages? If so, I'd recommend creating a branch in your repo that I can checkout and merge properly when the work is done.

If not, let me know, and I'll cherry-pick that commit.

Thanks for the help!

comment:9 Changed 8 years ago by feroze

I've fixed the names for Korean, Catalan and Greek.

https://github.com/feroze/vidalia/commits/language

comment:10 Changed 8 years ago by chiiph

Resolution: fixed
Status: needs_revisionclosed

Merged, thanks! It will be out with 0.2.18.

Note: See TracTickets for help on using tickets.