Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#5124 closed enhancement (fixed)

Get rid of the last 'opt' strings in descriptors?

Reported by: arma Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: easy tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For a long time now 'opt' has been optional. So long that we can drop it from descriptor lines, yes?

I see it in "protocols", "fingerprint", "extra-info-digest", "hidden-service-dir".

Child Tickets

Change History (8)

comment:1 Changed 9 years ago by nickm

Yes; "opt" can go.

comment:2 Changed 9 years ago by nickm

Keywords: easy added

comment:3 Changed 9 years ago by karsten

Pasting atagar's comment from duplicate ticket #5419 here:

Pushed the spec changes to my 5419 branch:
https://gitweb.torproject.org/user/atagar/torspec.git/commitdiff/4eb029b965adbcb407da5518047dc7536ab7ca2d

comment:4 Changed 9 years ago by atagar

Status: newneeds_review

Changing status so this catches Nick's eye. Doesn't include the tor part yet, but we can at least wipe it from the spec.

comment:5 Changed 8 years ago by nickm

Merged atagar's patch to tor-spec.

First cut of an attempt to remove "opt" in branch "bug5124" in my public repository. Needs review and testing

comment:6 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Seems to work okay; still looks fine 7 weeks later.
merging

comment:7 Changed 8 years ago by nickm

Keywords: tor-relay added

comment:8 Changed 8 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.