Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#5139 closed defect (fixed)

Bogus comment in router_rebuild_descriptor

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-bridge
Cc: arma, asn Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From router_rebuild_descriptor in src/or/router.c:

  ri->purpose =
    options->BridgeRelay ? ROUTER_PURPOSE_BRIDGE : ROUTER_PURPOSE_GENERAL;
  ri->cache_info.send_unencrypted = 1;
  /* Let bridges serve their own descriptors unencrypted, so they can
   * pass reachability testing. (If they want to be harder to notice,
   * they can always leave the DirPort off). */
  if (ei && !options->BridgeRelay)
    ei->cache_info.send_unencrypted = 1;

This comment doesn't quite match the behaviour of the code. Also, a bridge's DirPort option is now forced off.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

The behavior is a little silly too; there's no reason for bridges to have send_unencrypted set on anything. See branch bug5139 for a fix to both issues.

comment:2 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Still looks trivially correct to me; merging. (Thwunk!)

comment:3 Changed 7 years ago by nickm

Keywords: tor-bridge added

comment:4 Changed 7 years ago by nickm

Component: Tor BridgeTor
Note: See TracTickets for help on using tickets.