Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5183 closed defect (fixed)

Localize "Spoof English" prompt's radiobutton values

Reported by: rransom Owned by: mikeperry
Priority: High Milestone: TorBrowserBundle 2.2.x-stable
Component: TorBrowserButton Version:
Severity: Keywords: tbb-usability, MikePerry201303
Cc: Actual Points: 0.5
Parent ID: Points:
Reviewer: Sponsor:

Description

estebanm reproduced this bug with an “es_ES.UTF-8” locale. This isn't so bad for Spanish (in which “No” translates to “No”), but imagine this happening in a Korean or Farsi TBB.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by mikeperry

Summary: Spanish TBB asks users whether to request English web pages; shows ‘Yes’ and ‘No’ buttonsLocalize "Spoof English" prompt's radiobutton values

The strings in question are in torbutton_prompt_for_language_preference() in torbutton.js.

comment:2 Changed 8 years ago by mikeperry

Milestone: TorBrowserBundle 2.2.x-stable

comment:3 Changed 7 years ago by mikeperry

Component: Firefox Patch IssuesTorBrowserButton
Keywords: tbb-usability MikePerry201303 added
Resolution: fixed
Status: newclosed

I just pushed a fix for this to torbutton's origin/master. Will appear in the next TBB-stable that ships with Torbutton 1.5.1.

comment:4 Changed 7 years ago by mikeperry

Actual Points: 0.5
Note: See TracTickets for help on using tickets.