Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5191 closed defect (fixed)

mp->transports' contents types should not change by time

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: pt tor-bridge
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

  /* The 'transports' list contains all the transports this proxy has
     launched.

     Before a managed_proxy_t reaches the PT_PROTO_COMPLETED phase,
     this smartlist contains a 'transport_t' for every transport it
     has launched.

     When the managed_proxy_t reaches the PT_PROTO_COMPLETED phase, it
     registers all its transports to the circuitbuild.c subsystem. At
     that point the 'transport_t's are owned by the circuitbuild.c
     subsystem.

     To avoid carrying dangling 'transport_t's in this smartlist,
     right before the managed_proxy_t reaches the PT_PROTO_COMPLETED
     phase we replace all 'transport_t's with strings of their
     transport names.

     So, tl;dr:
     When (conf_state != PT_PROTO_COMPLETED) this list carries
     (transport_t *).
     When (conf_state == PT_PROTO_COMPLETED) this list carries
     (char *).
   */

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by asn

Keywords: pt added

My branch for #3589 fixes this issue, by refactoring mp->transports to always carry transport_ts.

comment:2 Changed 8 years ago by asn

Milestone: Tor: 0.2.4.x-final

comment:3 Changed 7 years ago by arma

Summary: mp->transports' contents types should not change by tmemp->transports' contents types should not change by time

Does the fact that #3589 is closed mean this ticket is complete too?

comment:4 in reply to:  3 Changed 7 years ago by asn

Resolution: fixed
Status: newclosed

Replying to arma:

Does the fact that #3589 is closed mean this ticket is complete too?

True. aecc728a5adce225c8415ca90121f2dd23f4f695 and its friends are now merged. Closing this one.

comment:5 Changed 7 years ago by nickm

Keywords: tor-bridge added

comment:6 Changed 7 years ago by nickm

Component: Tor BridgeTor
Note: See TracTickets for help on using tickets.