Opened 5 years ago

Closed 5 years ago

#5199 closed defect (fixed)

Interrupt doesn't stop integration testing when running multiple tests

Reported by: neena Owned by: atagar
Priority: Low Milestone:
Component: Core Tor/Stem Version:
Severity: Keywords:
Cc: neenaoffline@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When running multiple integration tests, Stem doesn't stop testing on receiving a keyboard interrupt. It stops the current test and continues with the next one. It should stop all testing and exit instead.

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by atagar

Yup, this is already listed on...
https://trac.torproject.org/projects/tor/wiki/doc/stem#Bugs

Patches welcome, otherwise this will be the case until this bubbles to the top of my todo list. I'll add this ticket to the wiki and use it to track the change.

It should be an easy fix if someone wants to take it on.

comment:2 Changed 5 years ago by neena

  • Cc neenaoffline@… added
  • Status changed from new to needs_review

Fixed this by having run_tests.py handle the signal instead of runner.py

My git branch that fixes this:

http://repo.or.cz/w/stem/neena.git/shortlog/refs/heads/multiple-tests-sigint

comment:3 Changed 5 years ago by atagar

  • Resolution set to fixed
  • Status changed from needs_review to closed

Perfect! Thanks, I've pushed the fix.
https://gitweb.torproject.org/stem.git/commitdiff/9a7b383c18e42cbce093803e8cdd04d98aa900c5

If you'd like to contribute further then let me know - email (http://www.atagar.com/contact/), irc, and trac all work for me.

Cheers! -Damian

Note: See TracTickets for help on using tickets.