Opened 7 years ago

Closed 7 years ago

#5207 closed defect (implemented)

ooni-probe should only set UseMicrodescriptors 0 if Tor understands that option

Reported by: karsten Owned by: hellais
Priority: Medium Milestone:
Component: Archived/Ooni Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: #5028 Points:
Reviewer: Sponsor:

Description

I'm running ooni-probe with Tor 0.2.2.x which doesn't understand UseMicrodescriptors 0. Maybe ooni-probe could check Tor's version and either set that option or not.

Child Tickets

Change History (3)

comment:1 Changed 7 years ago by hellais

Resolution: fixed
Status: newclosed

This is fixed in ea2083a9eea4af6a5d06301263b82ae6e64e56b2

comment:2 Changed 7 years ago by karsten

Resolution: fixed
Status: closedreopened

Minor bug in ea2083a: tor_greater_than('0.2.2') causes an ERROR: "Error in parsing your Tor version string: Tor version 0.2.2.35 (git-73ff13ab3cc9570d)." Looks like that function requires 4 ints, not just 3. Also, the right version to compare with is 0.2.3.2, not 0.2.2.x. Change that code to tor_greater_than('0.2.3.2'), and it'll work just fine.

Here's a comment that you could add to explain why we compare to 0.2.3.2: "The UseMicrodescriptors torrc option was first introduced in 0.2.3.2-alpha with a default value of 0. Earlier versions don't understand that option. 0.2.3.3-alpha was the first version that required explicitly setting UseMicrodescriptors 0 to go back to old-style consensus and descriptors, which is what we want here. Hence, set that option only in versions greater than 0.2.3.2."

Also, it's kinda annoying to read the WARN message "You run an outdated version of Tor: Tor version 0.2.2.35 (git-73ff13ab3cc9570d). (< 0.2.3.2)" for every tested bridge. We look at the version string only to say whether Tor will understand the UseMicrodescriptors torrc option, not to check if it's recent enough to run our test. Maybe the WARN message should only be emitted outside of tor_greater_than if the caller isn't happy with the result.

comment:3 Changed 7 years ago by hellais

Resolution: implemented
Status: reopenedclosed

These changes are integrated into:

commit 4174c99dda431e1ab4b891e0c6f59a4b5282c5c7
commit b8d0d4a071c584dbfdf5af942ead18525abe5d41

Note: See TracTickets for help on using tickets.