Opened 7 years ago

Closed 7 years ago

#5224 closed task (fixed)

Allow rulesets to be different in Firefox and Chrome releases

Reported by: pde Owned by: pde
Priority: High Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: schoen Actual Points:
Parent ID: #5196 Points:
Reviewer: Sponsor:

Description (last modified by pde)

Working around#5196 is going to require a temporary divergence in the GoogleAPIs ruleset in order to work around a Chrome bug.

Right now I can think of two ways to do this. One is to add a new attribute to <rule> elements which specifies that the only work on some platforms. Another is to build the Chrome releases from a different git branch.

The new rule element is probably slightly more elegant, and also slightly more work.

Child Tickets

Change History (6)

comment:1 Changed 7 years ago by pde

Parent ID: #5196

comment:2 Changed 7 years ago by pde

Priority: normalmajor

comment:3 Changed 7 years ago by pde

Type: defecttask

comment:4 Changed 7 years ago by pde

Description: modified (diff)

If we go the XML road, we could add a <ruleset> attribute to control which rulesets are on/off by default on various platforms; or a <rule> attribute to say that certain rewrites only happen on some platforms; or both.

Doing something at the <ruleset> level might allow us to handle other cases like the fact that some platforms trust the CACert root and others do not (#3776).

comment:5 Changed 7 years ago by pde

We decided to do this with a platform attribute for ruleset elements, documented here:

https://www.eff.org/https-everywhere/rulesets#platform

This is currently implemented on Chromium; we can add other implementations soon.

comment:6 Changed 7 years ago by pde

Resolution: fixed
Status: newclosed

Firefox now done too

https://gitweb.torproject.org/https-everywhere.git/commitdiff/43d218ccaf4fc5d9b06cfbad40efbfad3e7b2f9a

Note: See TracTickets for help on using tickets.