Opened 8 years ago

Closed 7 years ago

#5230 closed enhancement (fixed)

Use the 'owning controller' feature in ooni-probe/bridget

Reported by: karsten Owned by: hellais
Priority: Medium Milestone:
Component: Archived/Ooni Version:
Severity: Keywords:
Cc: rransom Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

15:26:50 < rransom_> I would also recommend using the 'owning 
                     controller' feature (#3049) to ensure that stray 
                     Tor processes don't stay around for long.

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by hellais

Is this command inside of PyTorCtl? Stem?

comment:2 Changed 8 years ago by karsten

Cc: rransom added

comment:3 in reply to:  1 Changed 8 years ago by rransom

Replying to hellais:

Is this command inside of PyTorCtl? Stem?

How should I know? I don't use either.

Read section 3.23 of control-spec.txt for how to use this feature.

comment:4 Changed 8 years ago by atagar

Is this command inside of PyTorCtl? Stem?

Nope. This feature was not added to TorCtl and Stem will support it but isn't yet feature complete. Sorry. :(

comment:5 Changed 8 years ago by hellais

Ok, is it safe to think of this as a future enhancement, but not work on implementing it right now?

comment:6 in reply to:  5 Changed 8 years ago by rransom

Replying to hellais:

Ok, is it safe to think of this as a future enhancement, but not work on implementing it right now?

Only if you're certain that your bridge tester will never crash.

If you leave old Tor processes running, they will continue to occupy their SOCKS and control ports. If you leave old Tor processes running and delete their data directories, they will probably break far more spectacularly. Don't leave old Tor processes running.

The ‘owning controller’ feature is the easiest way to not leave old Tor processes running. If you don't want to set one command-line option and send two control-port commands, you'll have to find some other way to identify still-running Tor processes and end them before your datadir-reaper process makes them go truly crazy.

comment:7 Changed 7 years ago by hellais

Resolution: fixed
Status: newclosed

We have now switched to using txtorcon for bridget and txtorcon implements the TAKECONTROL 'owning controller' feature already (http://txtorcon.readthedocs.org/en/latest/)

Closing it as resolved.

Note: See TracTickets for help on using tickets.