Opened 7 years ago

Closed 6 years ago

#5249 closed enhancement (wontfix)

Add orport parameter to Onionoo

Reported by: karsten Owned by: karsten
Priority: Low Milestone:
Component: Metrics/Onionoo Version:
Severity: Keywords:
Cc: phw, rndm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We could support searches for ip:port combinations. That might be useful for machines running more than 1 relay. In theory, there shouldn't be many relays per IP, but it wouldn't hurt to support this search.

The only question is whether Tomcat supports ":" in URLs. ;)

When implementing this we can't just look at summary documents anymore to see which relays match. We'll have to look at details documents, too. Shouldn't be too difficult, though.

(This was issue 11 in my GitHub repository.)

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by karsten

Resolution: wontfix
Status: newclosed

I decided against implementing this feature.

The current search parameter looks for addresses, not ports. Addresses include OR addresses which have one or more OR ports and exit addresses which don't have any port. Now, we could ignore the given port for exit addresses, or we could interpret searches for ports as searches for OR addresses only. But both solutions are rather ugly.

What we could do is add a new parameter orport=:orport. But given that there may soon be a Python Onionoo which needs to re-implement everything that's in the Java Onionoo, I'm not going to add new features which may or may not be used in the future.

Closing as wontfix.

comment:2 Changed 7 years ago by karsten

Priority: normalminor
Resolution: wontfix
Status: closedreopened

Ah well, maybe wontfix isn't the right resolution. wontfixrightnow is what I was looking for. Re-opening and changing priority to minor, so that this doesn't get lost. Still, I think if we want to do it, adding an orport parameter is the only viable solution.

comment:3 Changed 6 years ago by karsten

Cc: phw rndm added
Summary: Support searching for ip:port combinationsAdd orport parameter to Onionoo

Changed my mind again. An orport parameter is hardly needed at all. If there are machines with more than 1 relay per IP address, the application that queries Onionoo could easily filter the Onionoo result itself. Closing as won't fix. Cc'ing Atlas and Globe maintainers phw and rndm, just in case they feel that adding such a parameter would be a fantastic idea. In that case, please re-open this ticket!

comment:4 Changed 6 years ago by karsten

Resolution: wontfix
Status: reopenedclosed
Note: See TracTickets for help on using tickets.