BridgeT: Check if bridges are public relays

Thus, spoke arma - < armadev> gsathya: feature request: when your ooni learns the bridge descriptor behind an obfsproxy, check if it's a public relay and warn if so.

Basically, queries onionoo to see if the bridge is public. https://github.com/gsathya/ooni-probe/commit/f26af2d6d67f94c09586dd8b9360f294a5bdc55d

added bridge component::archived/ooni owner::isis parent::6414 priority::medium reachability resolution::not a bug status::closed type::enhancement labels

Trac:
Summary: BridgeT: Check if bridges are public to BridgeT: Check if bridges are public relays

Query onionoo through Tor - All requests are done through Tor now. Also, Onionoo URL is now a global variable.

https://github.com/gsathya/ooni-probe/commit/59e3e0e3ced2ce85f1799ea36ed0bd77abb04401

Trac:
Status: new to needs_review

Thanks. Merged. Maybe we should make this optional though, as it will drastically reduce performance of bridge scanning.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Replying to hellais:

Thanks. Merged. Maybe we should make this optional though, as it will drastically reduce performance of bridge scanning.

That was quick! Thanks! Optional sounds fine, but I doubt this reduces performances as much as the bandwidth testing?

Wait, you're transmitting all bridge fingerprints via HTTP GET requests to my personal VM. Please don't do that.

A better approach would be to download the list of currently running relays when BridgeT starts and compare locally. If you want, you can update that list every, say, 5--15 minutes, though not for every bridge scan.

Also note the onionoo.torproject.org URL in that link. Please put that in instead of the IP address, so that we can move the service in the future without breaking BridgeT.

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Replying to karsten:

Wait, you're transmitting all bridge fingerprints via HTTP GET requests to my personal VM. Please don't do that.

A better approach would be to download the list of currently running relays when BridgeT starts and compare locally. If you want, you can update that list every, say, 5--15 minutes, though not for every bridge scan.

Also note the onionoo.torproject.org URL in that link. Please put that in instead of the IP address, so that we can move the service in the future without breaking BridgeT.

This sounds reasonable. For the time being I have commented out in BridgeT the lines that do the check for bridge publicness in commit bd383663eff8703e0a78704703dbfba4dba46992.

If we want this feature it should be integrated as karsten suggested.

Trac:
Type: defect to enhancement

I'm adding this as a feature to the new bridge reachability tests.

Trac:
Owner: hellais to isis
Cc: gsathya to gsathya, isis@torproject.org
Parent: N/A to #6414 (closed)
Keywords: N/A deleted, bridge reachability added
Status: reopened to assigned

This was reimplemented here, though the bridge tests are currently blocking on incompatibility with OONI's API change.

Trac:
Status: assigned to needs_revision

Replying to isis:

This was reimplemented here, though the bridge tests are currently blocking on incompatibility with OONI's API change.

What exactly is the issue?

The part of code you mention there is not being called anywhere. If you ping me on IRC I can help you get it to work.

Also you may want to take a look at the comments I made here: https://gitweb.torproject.org/ooni-probe.git/blob/6a3ee55b574adaa8740ccafe2e4a01719dc0e86e:/ooni/utils/onion.py.

Most of the functions you have implemented there are already part of txtorcon, so I think it's not a good idea to have such amount of code duplication.

This ticket is no longer relevant, therefore I am going to close it.

Trac:
Resolution: N/A to not a bug
Status: needs_revision to closed

closed