Remove toggle-mode specific request observers

There might be a fair amount of performance overhead wrapped up in the multiple request observers in Torbutton. Many of these exist only because of hacks needed to safely support toggling and plugin-blocking. We can probably improve performance quite a bit by removing them.

This also makes work like #5709 (moved)/#1506 (closed) simpler, as android is rather sensitive to observers, and the multiprocess "Electrolysis" model makes some of them unreliable anyways.

See also #5965 (closed).

changed milestone to %TorBrowserBundle 2.3.x-stable

added MikePerry201301d actualpoints::12 component::torbrowserbutton milestone::TorBrowserBundle 2.3.x-stable owner::mikeperry priority::high resolution::fixed status::closed type::enhancement labels

Most likely the fix for #4430 (closed) will put our session store filters in this category.. They are only periodic, but they are quite expensive if you have a lot of tabs open.

Trac:
Keywords: N/A deleted, MikePerry201211d added

This might also fix #6469 (closed).

This should also fix #6661 (closed) and potentially a few other related website failures.

See also #5965 (closed), #1506 (closed) and #5709 (moved). This ticket is on the way to those tree.

Trac:
Description: There might be a fair amount of performance overhead wrapped up in the multiple request observers in Torbutton. Many of these exist only because of hacks needed to safely support toggling and plugin-blocking. We can probably improve performance quite a bit by removing them.

Doing so would mean we'd have to more aggressively deprecate Torbutton (#3838 (closed)), which blocks on an autoupdater.

to

There might be a fair amount of performance overhead wrapped up in the multiple request observers in Torbutton. Many of these exist only because of hacks needed to safely support toggling and plugin-blocking. We can probably improve performance quite a bit by removing them.

This also makes work like #5709 (moved)/#1506 (closed) simpler, as android is rather sensitive to observers, and the multiprocess "Electrolysis" model makes some of them unreliable anyways.

See also #5965 (closed).

Trac:
Keywords: MikePerry201211d deleted, MikePerry201301d added

This is done in origin/master. It will go into Torbutton 1.5.0.

There are still more observers we could remove/simplify (see #7974 (closed) for example), but I removed all of the toggle-related ones.

Trac:
Status: new to closed
Resolution: N/A to fixed
Actualpoints: N/A to 12

closed

added 96h of time spent

mentioned in issue #5709 (moved)

mentioned in issue #6661 (closed)

mentioned in issue #6661 (closed)

mentioned in issue tpo/applications/tor-browser#5709 (closed)