Opened 8 years ago
Closed 7 years ago
#5279 closed enhancement (fixed)
Remove toggle-mode specific request observers
| Reported by: | mikeperry | Owned by: | mikeperry |
|---|---|---|---|
| Priority: | High | Milestone: | TorBrowserBundle 2.3.x-stable |
| Component: | TorBrowserButton | Version: | |
| Severity: | Keywords: | MikePerry201301d | |
| Cc: | Actual Points: | 12 | |
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description (last modified by )
There might be a fair amount of performance overhead wrapped up in the multiple request observers in Torbutton. Many of these exist only because of hacks needed to safely support toggling and plugin-blocking. We can probably improve performance quite a bit by removing them.
This also makes work like #5709/#1506 simpler, as android is rather sensitive to observers, and the multiprocess "Electrolysis" model makes some of them unreliable anyways.
See also #5965.
Child Tickets
Change History (7)
comment:1 Changed 8 years ago by
comment:2 Changed 7 years ago by
| Keywords: | MikePerry201211d added |
|---|
comment:4 Changed 7 years ago by
This should also fix #6661 and potentially a few other related website failures.
comment:5 Changed 7 years ago by
| Description: | modified (diff) |
|---|
comment:6 Changed 7 years ago by
| Keywords: | MikePerry201301d added; MikePerry201211d removed |
|---|
comment:7 Changed 7 years ago by
| Actual Points: | → 12 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
This is done in origin/master. It will go into Torbutton 1.5.0.
There are still more observers we could remove/simplify (see #7974 for example), but I removed all of the toggle-related ones.
Most likely the fix for #4430 will put our session store filters in this category.. They are only periodic, but they are quite expensive if you have a lot of tabs open.