smartlist_isin should be named smartlist_contains

changed milestone to %Tor: 0.2.4.x-final

added component::core tor/tor milestone::Tor: 0.2.4.x-final priority::medium resolution::implemented status::closed tor-client type::defect labels

Sensible. Presumably then smartlist_{string,digest,string_num}_isin{case,} should be renamed smartlist_contains{string,digest,int_as_string}{_case,}.

I'd take an automatically generated patch with accompanying script.

Please review branch "rename5285" in my public repository?

(I'd defer this to 0.2.4, but getting renames done before the forks means less pain later.)

Trac:
Status: new to needs_review

Actually, we have enough to do. Let's delay this to late in 0.2.4.x; it is good to do, but won't hurt anything to wait

Trac:
Milestone: Tor: 0.2.3.x-final to Tor: 0.2.4.x-final

This looks just fine to me. I still feel like too much of a n00b to do the merges, though, so I'll just comment here and let you.

okay. I'll let this languish till later in the 0.2.4.x cycle, so that we don't have as many volatile changes going on in 0.2.3.x to merge forward and conflict here.

I think we're done with volatile changes going on in 0.2.3, fwiw.

Trac:
Keywords: N/A deleted, tor-client added

Trac:
Component: Tor Client to Tor

Okay, now it's "Later in the 0.2.4.x cycle". Recreating and merging as "bug5285_v2"

Trac:
Status: needs_review to closed
Resolution: N/A to implemented

closed

mentioned in issue #7599 (moved)

moved to tpo/core/tor#5285 (closed)