Opened 8 years ago

Closed 7 years ago

#5307 closed defect (fixed)

Handle missing last_restarted field in Onionoo's details documents

Reported by: karsten Owned by: hellais
Priority: High Milestone:
Component: Metrics/Relay Search Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Some of Onionoo's details documents don't contain the "last_restarted" field that is, in theory, a required field. That's a specification error which is fixed as of 5 minutes ago. The field cannot be contained if a router descriptor cannot be found. Oops.

Atlas needs to handle details documents without the "last_restarted" field correctly. Searching for these relays will fail right now. Details documents without that field have "as_name" in their last line and can be found like this:

$ curl http://onionoo.torproject.org/details/relays > relays
$ grep -E "fingerprint|as_name" relays | grep -v "as_name.*,$" | grep -B1 "as_name"

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by karsten

Status: newneeds_review

Please review branch task-5307 in my public repository. Note that it's based on my task-5832 branch, not on master. If task-5832 cannot be merged yet, I can rebase to master. Thanks!

comment:2 in reply to:  1 Changed 7 years ago by hellais

Replying to karsten:

Please review branch task-5307 in my public repository. Note that it's based on my task-5832 branch, not on master. If task-5832 cannot be merged yet, I can rebase to master. Thanks!

The patch looks good though I am unable to obtain a list of relays without the last_restarted flag, because of: #7701.

Also I believe the command line required to get the list of relays has changed to:

{{
curl https://onionoo.torproject.org/details > relays
}}

comment:3 Changed 7 years ago by karsten

#7701 is now fixed, though it only affected bridges, not relays. (But I'm glad you found that bug anyway!)

And yes, the command line has changed, but to:

curl https://onionoo.torproject.org/details?type=relay > relays

comment:4 Changed 7 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Merged and deployed. Closing.

Note: See TracTickets for help on using tickets.