Opened 8 years ago

Closed 8 years ago

#5314 closed defect (fixed)

sha256.h has no copyright line at the top

Reported by: weasel Owned by: asn
Priority: Medium Milestone:
Component: Archived/Obfsproxy Version: Obfsproxy: 0.1.0
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

sha256.h is the only file without a copyright line, all the others have one. Maybe we can add one?

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by asn

Do you think that:

/* Copyright (c) 2009-2011, The Tor Project, Inc. */

is sufficient?

Or should we do that ...2009-2012...?
Or something else?

comment:2 Changed 8 years ago by arma

Sounds good. 2009-2012 is also fine. Any convention will do. (Legally speaking, whether you claim copyright in 2012 after claiming it in 2011 only matters in another 80 or 150 years or something. For that matter, I think it may even never matter.)

comment:3 Changed 8 years ago by nickm

The struct definitions and headers would seem likely to be the ones from libtomcrypt; it should credit that in the same way that sha256.c does.

comment:4 Changed 8 years ago by asn

Status: newneeds_review

Please see bug5314 in https://git.gitorious.org/obfsproxy/obfsproxy.git.

From what I gather from the comments, it's OK to put

/* Copyright (c) 2009-2012, The Tor Project, Inc. */

on top of src/sha256.h:
https://gitorious.org/obfsproxy/obfsproxy/commit/669cce6ff5116230d6c0bd49a5c35d19cb3a6453

I'll put this in needs_review for a short while before merging, just in case I didn't read the comments correctly and merging this branch will result in a horde of lawyers trying to kill me.

comment:5 Changed 8 years ago by nickm

Status: needs_reviewneeds_revision

Please also add the comment about LibTomCrypt that appears in sha256.c.

comment:6 in reply to:  5 Changed 8 years ago by asn

Status: needs_revisionneeds_review

Replying to nickm:

Please also add the comment about LibTomCrypt that appears in sha256.c.

Right. I also updated the LICENSE file to include src/sha256.h.
Please see bug5314_take2 in https://git.gitorious.org/obfsproxy/obfsproxy.git.

https://gitorious.org/obfsproxy/obfsproxy/commit/05c5a804424de78287b1bd27ae14eda11b6df642

comment:7 Changed 8 years ago by asn

Resolution: fixed
Status: needs_reviewclosed

Merged bug5314_take2.

Note: See TracTickets for help on using tickets.