Opened 8 years ago

Closed 7 years ago

#5331 closed defect (fixed)

BridgeDB should re-open log files upon HUP

Reported by: aagbsn Owned by: aagbsn
Priority: Medium Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Keywords:
Cc: weasel Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

BridgeDB does not re-open log files after HUP.
This functionality is needed for log rotation.

Child Tickets

Attachments (1)

5331-bridgedb-rotate-logfiles.patch (1.9 KB) - added by aagbsn 8 years ago.
add logfile rotation to BridgeDB

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by aagbsn

add logfile rotation to BridgeDB

comment:1 Changed 8 years ago by aagbsn

Status: newneeds_review

https://gitweb.torproject.org/user/aagbsn/bridgedb.git/shortlog/refs/heads/5331-bridgedb-rotate-logfiles

Tested with LOGFILE = None, LOGFILE = "bridgedb.log" and default log rotation settings, and LOGFILE = "bridgedb.log" with custom log rotation settings.

Note: logs are not gzipped.

comment:2 Changed 8 years ago by weasel

This patch doesn't address the fact that bridgedb doesn't re-open the files on HUP.

It does however solve the real issue which is that we need some sort of log rotation.

The patch looks similar to what I sent you, but I haven't tried it. Let's push it to master and find out if it works?

comment:3 Changed 7 years ago by aagbsn

Resolution: fixed
Status: needs_reviewclosed

Log rotation has been working fine on ponticum.tpo.

I think we can mark this one as closed.

Note: See TracTickets for help on using tickets.