parse_http_time is borked

In his unit test adventures, emanchado found some problems with parse_http_time. Notably, the "Wednesday, 07 March 2012..." syntax was broken. Also, the months were all wrong when they got looked up by name.

I'm going to extract the patches to test and fix that into a separate branch so it can go on 0.2.2.x.

changed milestone to %Tor: 0.2.2.x-final

added component::core tor/tor milestone::Tor: 0.2.2.x-final priority::medium resolution::fixed status::closed tor-client type::defect labels

See branch "bug5346" in my public repository.

Trac:
Status: new to needs_review

Review has turned up some other crazy things in our time parsing/handling.

wanoskarnet has found some places where we allow tm_sec to be up to 61. That's wrong; 60 is the highest supported value. We should grep for tm_sec to find all the cases of this.

Sebastian notes that some of our checks are based on incorrectly assuming tm_mon ranges from 1 to 12, rather than the correct 0..11. Further, tm_mday shouldn't be able to be 0 in a canonical date, but we seem to allow that.

Trac:
Status: needs_review to needs_revision

I also think we should do some gmtime stuff at the end of parse_http_time(), just to make sure we created a valid struct tm.

Pushed bug5346 again to fix those, and a ridiculous case where we were initializing hours=minutes=seconds=100 for no credible reason.

Trac:
Status: needs_revision to needs_review

you didn't fix

tm->tm_mon < 1 || tm->tm_mon > 12 ||

I'm making a branch here with a fix

So, what about using gmtime? Also, in parse_http_time(), we don't set tm_wkday. I wonder if we should?

I'm making a branch here with a fix

Not seeing the fix.

So, what about using gmtime?

It would be okay by me.

Also, in parse_http_time(), we don't set tm_wkday. I wonder if we should?

I think we're in the clear so long as we don't use it, and document that we don't set it.

Trac:
Status: needs_review to needs_revision

Looking through all the code, I squashed it some and merged your tests. Right now, I'm happy to merge it as-is.

Trac:
Status: needs_revision to needs_review

(see my branch "bug5346_squashed")

Still looks okay to me. Merging into maint-0.2.2 and forward.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Keywords: N/A deleted, tor-client added

Trac:
Component: Tor Client to Tor

closed

moved to tpo/core/tor#5346 (closed)