Opened 8 years ago

Closed 7 years ago

#5357 closed defect (fixed)

Ruleset crushing code trips on corner cases

Reported by: pde Owned by: pde
Priority: Low Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: alex_y_xu@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by pde)

This ruleset:

https://gitweb.torproject.org/https-everywhere.git/commitdiff/41ad47b404820ffecf178a969d24ed091a98f6fe

Triggered a bug in Alex's ruleset crushing code in the build script. The symptom was that HTTPS Everywhere could no longer parse the resulting default.rulesets file.

Re-spacing it was an effective workaround, but at some point we should fix those regexps or replace them with something more elegant in Python.

Child Tickets

Change History (2)

comment:1 Changed 8 years ago by pde

Description: modified (diff)

comment:2 Changed 7 years ago by pde

Resolution: fixed
Status: newclosed

Closing this for now since we have different crushing code.

Note: See TracTickets for help on using tickets.