Opened 8 years ago

Closed 8 years ago

#5364 closed defect (fixed)

less redundancy for Browser Bundle Settings under Plugins

Reported by: sirop Owned by: chiiph
Priority: Medium Milestone:
Component: Archived/Vidalia Version: Vidalia: 0.3.1-alpha
Severity: Keywords: vidalia plugins
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Plugins-> Browser Bundle Settings -> Directory  is kind of misleading.

One might think that something like /home/tor-browser-2.2.35-7.2-dev/App/Firefox/ is needed.

However, if you look at tbb.js, launchBrowserFromDirectory: function() , you can see that

only /home/tor-browser-2.2.35-7.2-dev is meant as vdebug() lets me guess.

So either rewrite launchBrowserFromDirectory: function() or rename  Plugins-> Browser Bundle Settings -> Directory into something like TOR Browser Bundle Directory.

Need your advice.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by sirop

Status: newneeds_information

comment:2 Changed 8 years ago by chiiph

Owner: changed from sirop to chiiph
Status: needs_informationaccepted

Do you mean a complete rewrite of the function or just the way the path is handled?

I think the easiest way for this would be to rename the label.

comment:3 in reply to:  2 ; Changed 8 years ago by sirop

Replying to chiiph:

I think the easiest way for this would be to rename the label.

Yes, I also think, to rename the label would be quicker.

comment:4 in reply to:  3 Changed 8 years ago by sirop

Status: acceptedneeds_information

Replying to sirop:

Replying to chiiph:

I think the easiest way for this would be to rename the label.

Yes, I also think, to rename the label would be quicker.

launchBrowserFromDirectory: function() {

189 vdebug("TBB@launchBrowserFromDirectory");
190 var browserDirectoryFilename = this.tab.getSetting(this.BrowserExecutable, "");
191 var browserDirectory = this.tab.getSetting(this.BrowserDirectory, "");
192
193 this.browserProcess.setEnvironment(this.updateBrowserEnv());
194
195 var browserExecutable = QDir.toNativeSeparators(browserDirectory + "/App/Firefox/" +
196 browserDirectoryFilename);

Well, browserDirectory is already Tor-browser/App/Firefox or not?

197
198 var profileDir = QDir.toNativeSeparators(browserDirectory + "/Data/profile");
199 var browserDirObj = new QDir(browserDirectory);
200
201 /* Copy the profile directory if it's not already there */
202 if(!browserDirObj.exists("Data/profile")) {
203 browserDirObj.mkpath("Data/profile");
204 this.copy_dir(browserDirectory + "/App/DefaultData/profile", browserDirectory + "/Data/profile");
205 }

As I see in tor-browser-2.2.35-7.2-dev, Data/profile is already there.
App/DefaultData/profile is not in tor-browser-2.2.35-7.2-dev .

206
207 /* Copy the plugins directory if it's not already there */
208 if (!browserDirObj.exists("Data/plugins")) {
209 browserDirObj.mkpath("Data/plugins");
210 this.copy_dir(browserDirectory + "/App/DefaultData/plugins", browserDirectory + "/Data/plugins");
211 }

As I see in tor-browser-2.2.35-7.2-dev , Data/plugins is already there.

212
213 /* Build the command line arguments */
214 /* Is this better or worse than MOZ_NO_REMOTE? */
215 var commandLine = "-no-remote ";
216 commandLine += "-profile ";
217 commandLine += profileDir;
218
219 /* Launch the browser */
220 this.browserProcess.start(browserExecutable, commandLine);
221 this.browserProcess.toForeground()
222 },

Should we let Tor Browser directory be tor-browser-directory and not tor-browser-directory/App/Firefox?
Do we really need to copy both Data/* directories?

comment:5 Changed 8 years ago by chiiph

Resolution: fixed
Status: needs_informationclosed

This was fixed both in vidalia:master and vidalia-plugins.

Note: See TracTickets for help on using tickets.