Opened 7 years ago

Last modified 23 months ago

#5392 needs_revision task

Write proposal for n23 patch behavior

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: needs-proposal tor-relay research-program
Cc: malsabah@…, iang@… Actual Points:
Parent ID: #4506 Points:
Reviewer: Sponsor:


In #4488 we located and updated the n23 patch from the Defenestrator paper. It's now in branch 'n23-2' in my git repo.

The next step is to refactor connection_or_consider_sending_flowcontrol_cell(). To do that, we need to know what the function is *supposed* to be doing.

Under what circumstances do we send a flowcontrol cell, and how do we pick the values for it? Just as important, in what cases (e.g. if we're a client) do we *not* send flowcontrol cells?

I'm hoping Mashael will do this, with Ian's help.

Child Tickets

Change History (10)

comment:1 Changed 7 years ago by arma

Cc: malsabah@… iang@… added

comment:2 Changed 7 years ago by arma

I pushed a "n23-mashael" branch to my git repo, with Mashael's patches. Next step is to look at them and clean them up.

comment:3 Changed 7 years ago by arma

Specifically, see the function comments on connection_or_consider_sending_flowcontrol_cell() for what we have of the spec currently.

I need some help from Nick to clean up the patch to be something mergeable into Tor. In parallel, we should see if simulations tell us anything.

comment:4 Changed 7 years ago by arma

Somebody should also rebase-or-whatever that branch to current master, so it receives all the other bugfixes since then.

comment:5 Changed 7 years ago by arma

The n23-3 branch in my git repo is n23-mashael, rebased onto today's master.

comment:6 Changed 7 years ago by arma

Summary: Write down intended behavior of n23 patchWrite proposal for n23 patch behavior

New plan here: we have some function comments in this branch. We should turn it into a proposal, where we explain the algorithm (so others can evaluate whether we've got it right), and where we talk about a transition path.

This ticket can wait until #4486 gets farther.

comment:7 Changed 7 years ago by nickm

Keywords: needs-proposal added

comment:8 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:9 Changed 7 years ago by nickm

Component: Tor RelayTor

comment:10 Changed 23 months ago by nickm

Keywords: research-program added
Severity: Normal
Status: newneeds_revision
Note: See TracTickets for help on using tickets.