Opened 8 years ago

Closed 4 years ago

#5400 closed defect (fixed)

ASLR broken by non-ASLR DLLs

Reported by: funkstar Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version: Vidalia: 0.3.1-alpha
Severity: Keywords: needs-triage
Cc: Shondoit Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The following DLLs do not opt into ASLR, but are loaded by Vidalia:

libgcc_s_dw2-1.dll
mingwm10.dll
QtCore4.dll
QtGui4.dll
QtNetwork4.dll
QtScript4.dll
QtXml4.dll

Child Tickets

Change History (18)

comment:1 Changed 8 years ago by arma

Is this a "how we built the qt that we link to Vidalia" issue, and thus a bundles/installation ticket?

comment:2 Changed 8 years ago by chiiph

Component: VidaliaTor bundles/installation
Owner: changed from chiiph to erinn

I'm not sure how to enable ASLR in Qt/mingw/libgcc, but I know it isn't something I can handle from the code.

comment:3 Changed 8 years ago by Sebastian

This isn't something we can easily fix yet, because we don't build Qt from Source on Windows. One day we will, but that's a bunch of work. The first two dlls are mingw-related, we should see if there aren't any aslr-enabled versions of those around maybe...

comment:4 Changed 8 years ago by Shondoit

Cc: Shondoit added

comment:5 Changed 7 years ago by funkstar

Just wondering if any progress on this?

comment:6 Changed 7 years ago by Sebastian

Partial progress, yes. We build Qt from source, but I haven't yet figured out how to get ASLR for mingw/libgcc. I wonder if we need to build that, too. That'd be rather insane tho.

comment:7 in reply to:  6 Changed 7 years ago by Shondoit

Replying to funkstar:

Just wondering if any progress on this?

For Windows we have a proposed patch to start building Qt from source. (See #5746)
Basically, when this gets merged it should all be ASLR enabled.
I analyzed the resulting binaries from that branch and all of them have 'dynamic base' and 'NX compatible' flags. (Apart from 'Start Tor Browser.exe', but this gets closed right away anyway.)

Replying to Sebastian:

Partial progress, yes. We build Qt from source, but I haven't yet figured out how to get ASLR for mingw/libgcc. I wonder if we need to build that, too. That'd be rather insane tho.

Oh ye o' little faith. Statically building Vidalia removes these dependencies. (As long as we add -static-libgcc, which I did)

comment:8 Changed 7 years ago by Sebastian

Interesting!

comment:9 Changed 7 years ago by funkstar

Good to hear! :)

comment:10 Changed 7 years ago by funkstar

So the unstable builds are FINALLY updated and I've installed tor again using the bridge bundle: vidalia-bridge-bundle-0.2.3.19-rc-0.2.20.exe

ASLR is NOT enabled in this version of Vidalia, is this correct? WHY is the unstable Tor not using the unstable Vidalia? (https://trac.torproject.org/projects/tor/ticket/6142)

comment:11 in reply to:  10 ; Changed 7 years ago by Shondoit

Replying to funkstar:

ASLR is NOT enabled in this version of Vidalia, is this correct?

This is correct; ASLR is still blocked by a lack of building Qt from source. (#5746)

comment:12 in reply to:  11 ; Changed 7 years ago by funkstar

Replying to Shondoit:

Replying to funkstar:

ASLR is NOT enabled in this version of Vidalia, is this correct?

This is correct; ASLR is still blocked by a lack of building Qt from source. (#5746)

In that ticket you mentioned you had made a branch after .19 which included your own build, it is now .20 and your branch has not been merged? Or is it merged on the unstable builds?

comment:13 in reply to:  12 Changed 7 years ago by Shondoit

Replying to funkstar:

In that ticket you mentioned you had made a branch after .19 which included your own build, it is now .20 and your branch has not been merged? Or is it merged on the unstable builds?

I have not had the time to update my branch to the current state (considering I'm only volunteering and working part-time.)
I will try to get #5746 working in the next month, which will automatically solve this.
It's unlikely that a new bundle will be released just for this, so it will come with the next regular update.

comment:14 Changed 6 years ago by funkstar

This is still an issue.

comment:15 Changed 6 years ago by funkstar

Bump, any progress?

comment:16 Changed 6 years ago by funkstar

Will this be resolved by the next official release?

comment:17 Changed 5 years ago by erinn

Keywords: needs-triage added

comment:18 Changed 4 years ago by cypherpunks

Resolution: fixed
Status: newclosed

The following DLLs do not opt into ASLR, but are loaded by Vidalia

Vidalia is deprecated.
Closing this ticket, please create a new one if it's an issue for latest TorBrowser.

Note: See TracTickets for help on using tickets.