Opened 8 years ago

Last modified 3 years ago

#5401 new enhancement

tag control log events so arm can know they're from the same place in the code

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client needs-spec tor-control
Cc: atagar Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Damian told me at the dev mtg that arm is doing regexp backbends to recognize log line duplicates (it will merge all the logs that are basically saying the same thing into one, to make it easier to see what else is going on). If we provide a tag along with the log event, we would make his life easier.

It occurred to me that we could easily add a new "filename:line" param to controller events, since we already know it. (The tag doesn't have to be consistent across runs, just within a run.) We would probably want to declare the tag string opaque, so controllers don't get any ideas about doing more with it.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by arma

Branch task5401 in my git repo is a start here. But I quickly ran into a problem:

4.1.5. Log messages

  The syntax is:
     "650" SP Severity SP ReplyText CRLF
     "650+" Severity CRLF Data 650 SP "OK" CRLF

     Severity = "DEBUG" / "INFO" / "NOTICE" / "WARN"/ "ERR"

There's no backward-compatible way in the protocol to send anything on the 650 DEBUG line except for the log message! Ooops.

This feature will be harder than I realized.

comment:2 Changed 8 years ago by nickm

Keywords: tor-client added

comment:3 Changed 8 years ago by nickm

Component: Tor ClientTor

comment:4 Changed 3 years ago by nickm

Keywords: needs-spec tor-control added
Severity: Normal
Note: See TracTickets for help on using tickets.