Opened 8 years ago

Closed 8 years ago

#5403 closed defect (fixed)

Presence of tor-resolve in bundles for different plataform is inconsistent

Reported by: amieiro Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The windows bundle includes the tor-resolve tool[1], but the Linux[2] and OS X[3] versions don't.

The question is: what is the desired behaviour? To have tor-resolve in all bundles or not to have it in the windows version?

[1] https://gitweb.torproject.org/torbrowser.git/blob/HEAD:/build-scripts/windows.mk#l250

[2] https://gitweb.torproject.org/torbrowser.git/blob/HEAD:/build-scripts/osx.mk#l248

[3] https://gitweb.torproject.org/torbrowser.git/blob/HEAD:/build-scripts/linux.mk#l244

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by Sebastian

Status: newneeds_review

After discussion on IRC, it seems we don't have tor-resolve on osx/linux because of the random ports feature which makes it very hard to use correctly, and on windows we probably shouldn't have it, because come on. It's currentl 366KB, and consensus on IRC (between arma and sebastian) was to remove it. Suggested patch in bug5403 in my repo. bug5403 in my repo

comment:2 in reply to:  1 Changed 8 years ago by arma

Replying to Sebastian:

and on windows we probably shouldn't have it, because come on.

Should we stick an exe somewhere for those rare users who might want it? I guess the followup question would be, how would they learn where it is?

I say we drop it from the tbb on the theory that nobody uses it, and see if anybody contradicts us. If they do, we can ask them where we should make it available as a separate file.

comment:3 Changed 8 years ago by erinn

Resolution: fixed
Status: needs_reviewclosed

Removed tor-resolve from the latest tbb. Closing.

Note: See TracTickets for help on using tickets.