Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5438 closed defect (fixed)

SocksListenAddress is deprecated but still used in default/sample torrc

Reported by: cypherpunks Owned by:
Priority: High Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version: Tor: 0.2.3.12-alpha
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This leads to problems such as: "SocksListenAddress can't be used when there are multiple SocksPort lines"

(that's using "experimental" deb repo)

Child Tickets

Change History (8)

comment:1 Changed 8 years ago by nickm

Component: - Select a componentTor Client
Milestone: Tor: 0.2.3.x-final

comment:2 Changed 8 years ago by arma

Priority: minormajor

Ok. For reference the current torrc.sample stanza is:

## Replace this with "SocksPort 0" if you plan to run Tor only as a
## relay, and not make any local application connections yourself.
SocksPort 9050 # what port to open for local application connections
SocksListenAddress 127.0.0.1 # accept connections only from localhost
#SocksListenAddress 192.168.0.1:9100 # listen on this IP:port also

What's the new behavior we want? Perhaps something like

## What address/port to open for local application connections.
## Replace this with "SocksPort 0" if you plan to run Tor only as a
## relay, and not make any local application connections yourself.
SocksPort 9050 # binds to localhost if address isn't specified
#SocksPort 192.168.0.1:9100 # listen on this IP:port also

I don't think we should have "socksport 127.0.0.1:9050" as default-on in the torrc file, because that limits us in the future about where we want it to bind. Do we want 9050 to be enabled by default in the torrc at all? It already is the default in the code -- see calls to parse_port_config().

Hm.

comment:3 Changed 8 years ago by nickm

I think arma's suggestion is fine; unless we get a better one, let's go with that.

comment:4 Changed 8 years ago by nickm

Status: newneeds_review

I pushed a branch "bug5438" to my public repo that does approximately that change, and removes the rest of the *ListenAddress options for torrc.sample too. Please review?

comment:5 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks like this got merged in 0.2.3.14-alpha.

comment:6 Changed 7 years ago by arma

As an addendum: we also removed the "SocksPort 9050" line, which might confuse users into thinking that Tor won't default to it. I guess we'll find out.

(It is now the case that torrc.sample has no uncommented lines.)

comment:7 Changed 7 years ago by nickm

Keywords: tor-client added

comment:8 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.