Opened 13 years ago

Last modified 8 years ago

#544 closed defect (Fixed)

bandwidth buckets are ints

Reported by: arma Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: arma, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Nov 06 12:09:57.592 [debug] global_read_bucket now 6291456.

Nov 06 13:10:20.167 [debug] global_read_bucket now -1815240658.
Nov 06 13:10:20.167 [debug] global_write_bucket now -1815085682.
Nov 06 13:10:20.167 [debug] global_relayed_read_bucket now 512000.
Nov 06 13:10:20.167 [warn] Your system clock just jumped 3517 seconds forward; a
ssuming established circuits no longer work.

This overflow is probably a bug in 0.1.2.x too.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (5)

comment:1 Changed 13 years ago by nickm

The problem is not that they're ints; the problem is that they can under/overflow so horribly. Any type can
roll over; to be correct, we need to catch these overflows/underflows.

comment:2 Changed 13 years ago by nickm

Fixed in r12400.

comment:3 Changed 13 years ago by nickm

Also see r12401. Backported as r12402.

comment:4 Changed 13 years ago by nickm

flyspray2trac: bug closed.

comment:5 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.