Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5444 closed defect (wontfix)

apply debian patch for tor2web mode

Reported by: aaronsw Owned by: weasel
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

rransom's patch allowing debian packages with tor2web mode to be built was never applied -- can someone merge it?

https://trac.torproject.org/projects/tor/attachment/ticket/2553/0001-Add-support-for-an-enable-tor2web-mode-DEB_BUILD_OPT.patch

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by rransom

Component: Tor ClientTor bundles/installation
Owner: changed from rransom to weasel
Status: newassigned
Version: Tor: unspecified

(Note that weasel prefers that bugs regarding the Tor Debian packages be filed in the Debian BTS.)

comment:2 Changed 8 years ago by aaronsw

Also, the test doesn't work because it doesn't test with a torrc with Tor2webMode on, but I don't know how to fix this other than wiping out the tests:

echo "all:" > src/test/Makefile
echo "check:" >> src/test/Makefile
echo "install:" >> src/test/Makefile

comment:3 Changed 8 years ago by weasel

It's not entirely obvious to me why this is a compile time option, and what the (side-)effects are of building with it.

Furthermore it's not entirely clear why this needs to be in the source of the official Debian package.

Cheers,
weasel

comment:4 Changed 8 years ago by weasel

Resolution: wontfix
Status: assignedclosed

After some discussion on IRC it seems like this is not a feature that we want to support in this way.

Either it's a useful and (reasonable safe) thing to have, then we should just build all our tors with it (and do away with the --enable-$feature configure switch), or it's not and you want people to build their own tor.

Therefore I do not think it's a good idea to enable this feature unconditionally in debian/rules, and I don't think that adding debbuildoption flags to make your tor build somewhat different is the right answer either.

Furthermore, comment 2 seems to suggest that things either don't work, or at least that something is missing as of yet.

So, closing this without applying the patch.

comment:5 Changed 8 years ago by arma

Aaron, do the tor2web operators want to use a deb? If so, we should probably think about a better way to let them do it. (For example, maybe we should treat our users as grown-ups and let them be able to set the config option if they want to.)

Note: See TracTickets for help on using tickets.