Opened 8 years ago

Last modified 4 months ago

#5457 assigned defect

Bw auths don't count circuit failures in descriptor mode

Reported by: mikeperry Owned by:
Priority: Medium Milestone: sbws: unspecified
Component: Core Tor/sbws Version:
Severity: Normal Keywords:
Cc: aagbsn@…, mikeperry Actual Points:
Parent ID: #5456 Points:
Reviewer: Sponsor:

Description

When we are using descriptor bandwidth (ie no feedback), we are unable to properly use circuit failure statistics to penalize nodes that are either attempting path bias, or are just experiencing CPU overload.

The fix *should* be simple. I think we just need to add another clause in aggregate.py where we check for use_circ_fails to also check for use_desc_bw and properly combine the pid_error and circ_error for that case (perhaps just by multiplying them).

Child Tickets

Change History (8)

comment:1 Changed 7 years ago by mikeperry

Summary: Bw auths can't count circuit failures properly in compatibility modeBw auths don't count circuit failures in descriptor mode

#7023 is a dup of this.

comment:2 Changed 7 years ago by mikeperry

The circuit failure rate of the network appears to vary wildly. It also seems that it doesn't take much to push nodes into CPU overload. This is rather concerning, as it seems to indicate that measuring for CPU overload is very prone to DoS attacks designed to demote certain nodes from high bandwidth rankings.

We might not want to rush into this fix... :/

comment:3 Changed 5 years ago by aagbsn

Cc: aagbsn@… added

comment:4 Changed 2 years ago by teor

Severity: Blocker

We probably won't implement this in torflow, see #13630 for a replacement.

comment:5 Changed 2 years ago by teor

Severity: BlockerNormal

comment:6 Changed 2 years ago by teor

Priority: HighMedium

Priorities and Severities in torflow are meaningless, setting them all to Medium/Normal.

comment:7 Changed 4 months ago by gaba

Cc: mikeperry added
Owner: mikeperry deleted
Status: newassigned

comment:8 Changed 4 months ago by teor

Component: Core Tor/TorflowCore Tor/sbws
Milestone: sbws: unspecified

If we do this, it will be in sbws

Note: See TracTickets for help on using tickets.