Opened 6 years ago

Closed 11 months ago

#5500 closed enhancement (implemented)

make check should check-spaces

Reported by: arma Owned by: cypherpunks
Priority: Low Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I think we released an alpha tarball that fails make check-spaces.

nick says it's fine with him if we make 'make test' include make check-spaces.

I think a slightly better option is to make 'make dist' include it.

Is it as simple as changing
"dist: check"
to
"dist: check check-spaces"
in Makefile.am?

Turns out not to be quite that simple -- that runs check-spaces but doesn't stop if check-spaces is unhappy.

Child Tickets

TicketTypeStatusOwnerSummary
#20984defectclosedcypherpunksClean up the check-spaces script

Change History (17)

comment:1 Changed 6 years ago by nickm

that runs check-spaces but doesn't stop if check-spaces is unhappy.

The issue there is probably that the checkSpaces.pl script doesn't actually exit with a nonzero code when it finds a problem.

Do we care that this makes us build-depend on perl? That seems a little ugly. I guess we could do an "if test which perl != ""; then" around it or something.

comment:2 Changed 6 years ago by arma

You're right that adding a perl dependency to our build process is silly.

comment:3 Changed 5 years ago by nickm

Keywords: tor-client added

comment:4 Changed 5 years ago by nickm

Component: Tor ClientTor

comment:5 Changed 11 months ago by cypherpunks

Owner: set to cypherpunks
Severity: Normal
Status: newassigned
Summary: make dist should check-spacesmake check should check-spaces

I'm picking this up. Changed the summary because IMO it makes more sense to run check-spaces with make check.

Changed 11 months ago by cypherpunks

Changed 11 months ago by cypherpunks

Changed 11 months ago by cypherpunks

Changed 11 months ago by cypherpunks

comment:6 Changed 11 months ago by cypherpunks

Status: assignedneeds_review

Changed 11 months ago by cypherpunks

comment:7 Changed 11 months ago by cypherpunks

Added a missing changes file.

comment:8 Changed 11 months ago by teor

Keywords: tor-client removed
Milestone: Tor: unspecifiedTor: 0.3.0.x-final
Status: needs_reviewmerge_ready

These all seem like sensible changes, but I'd like nickm to review before they are merged.

comment:9 Changed 11 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

This looks okay to me. Thanks for cleaning up my ugly ancient perl code!

Note: See TracTickets for help on using tickets.