Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#5508 closed defect (fixed)

Assertion on empty desc_stats

Reported by: ln5 Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This happens in rep_hist_format_desc_stats() if served_descs is empty:

container.c:1422 find_nth_int: Assertion nth < n_elements failed; aborting.

See branch empty_desc_stats in my repo for a fix.

Child Tickets

Change History (7)

comment:1 Changed 9 years ago by ln5

We might want to protect against dirreq_completed being empty in
geoip_get_dirreq_history() too.

median_uint32(dltimes, complete); /* sorts as a side effect. */

comment:2 Changed 9 years ago by nickm

Milestone: Tor: 0.2.3.x-final
Status: newneeds_review

Looks okay to me. Needs a changes file.

comment:3 Changed 9 years ago by ln5

Changes file added.

comment:4 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; thanks!

comment:5 Changed 9 years ago by arma

ln5: in your next changes file, be sure to mention the bug number in the text as well as the filename. Otherwise when I cat all the changes/* files together, the bug number gets lost.

comment:6 Changed 8 years ago by nickm

Keywords: tor-relay added

comment:7 Changed 8 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.