Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#5529 closed enhancement (implemented)

Move last_reachable and testing_since from routerinfo_t to node_t

Reported by: ln5 Owned by: ln5
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-auth
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In preparation for adding support for reachability testing over IPv6
(in bridge authorities to begin with), let's move last_reachable and
testing_since from routerinfo_t to node_t. routerinfo_t is supposed
to be imutable so it'd be sad to add more mutable members to it now.

Child Tickets

Change History (10)

comment:1 Changed 8 years ago by ln5

Status: newneeds_review

See bug5529 in my repo. It's based on bug5527.

comment:2 Changed 8 years ago by ln5

Beware. This is untested. I'll run some basic tests (bridge auth, bridge and client) in some 12h.

comment:3 Changed 8 years ago by ln5

Owner: set to ln5
Status: needs_reviewassigned

Tested on bridge auth, bridge (and client). Auth marks bridges as
reachable, bridges and clients work.

comment:4 Changed 8 years ago by ln5

Status: assignedneeds_review

comment:5 Changed 8 years ago by ln5

This kind of got lost in a twisted maze of bugs, all alike.

I've rebased on master and pushed to bug5529_rebased.
Please review.

comment:6 Changed 7 years ago by nickm

Status: needs_reviewneeds_revision

Looks mostly plausible.

Needs a changes file.

Maybe nodelist_replace_routerinfo and nodelist_add_routerinfo should get rolled into one function that takes the new routerinfo and does the right thing.

comment:7 Changed 7 years ago by ln5

Status: needs_revisionneeds_review

A changes file was added in commit 7bdcc6f2.

A suggested approach for merging nodelist_replace_routerinfo and
nodelist_add_routerinfo into a single function can be found in commit
6096b76d, branch bug5529_rebased. Would we want a sentence in the
changes file for this change too?

comment:8 Changed 7 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Implemented in the branch "tickets_5529_5534_5974_6406" based on Linus's enh6404, based on my ipv6-phase3-0711, based on Linus's ipv6-phase3-0711, etc etc.

Merged that branch.

comment:9 Changed 7 years ago by nickm

Keywords: tor-auth added

comment:10 Changed 7 years ago by nickm

Component: Tor Directory AuthorityTor
Note: See TracTickets for help on using tickets.