Move last_reachable and testing_since from routerinfo_t to node_t

In preparation for adding support for reachability testing over IPv6 (in bridge authorities to begin with), let's move last_reachable and testing_since from routerinfo_t to node_t. routerinfo_t is supposed to be imutable so it'd be sad to add more mutable members to it now.

changed milestone to %Tor: 0.2.4.x-final

added component::core tor/tor milestone::Tor: 0.2.4.x-final owner::ln5 priority::medium resolution::implemented status::closed tor-auth type::enhancement labels

See bug5529 in my repo. It's based on bug5527.

Trac:
Status: new to needs_review

Beware. This is untested. I'll run some basic tests (bridge auth, bridge and client) in some 12h.

Tested on bridge auth, bridge (and client). Auth marks bridges as reachable, bridges and clients work.

Trac:
Owner: N/A to ln5
Status: needs_review to assigned

Trac:
Status: assigned to needs_review

This kind of got lost in a twisted maze of bugs, all alike.

I've rebased on master and pushed to bug5529_rebased. Please review.

Looks mostly plausible.

Needs a changes file.

Maybe nodelist_replace_routerinfo and nodelist_add_routerinfo should get rolled into one function that takes the new routerinfo and does the right thing.

Trac:
Status: needs_review to needs_revision

A changes file was added in commit 7bdcc6f2.

A suggested approach for merging nodelist_replace_routerinfo and nodelist_add_routerinfo into a single function can be found in commit 6096b76d, branch bug5529_rebased. Would we want a sentence in the changes file for this change too?

Trac:
Status: needs_revision to needs_review

Implemented in the branch "tickets_5529_5534_5974_6406" based on Linus's enh6404, based on my ipv6-phase3-0711, based on Linus's ipv6-phase3-0711, etc etc.

Merged that branch.

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

Trac:
Keywords: N/A deleted, tor-auth added

Trac:
Component: Tor Directory Authority to Tor

closed

mentioned in issue #5533 (moved)

moved to tpo/core/tor#5529 (closed)