Opened 8 years ago

Closed 7 years ago

#5559 closed defect (fixed)

Not showing BadExit flag

Reported by: atagar Owned by: hellais
Priority: Low Milestone:
Component: Metrics/Relay Search Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Moving from irc since this is likely to be lost in the backlog...

08:38 < atagar> karsten, hellais_: Does atlas properly show the bad exit flag? Looks like it either doesn't or maybe it's being very slow to update compared to torstatus.

08:38 < atagar> https://atlas.torproject.org/#details/FFD2075CC29852C322E1984555CDDFBC6FB1EE80

08:38 < atagar> http://torstatus.blutmagie.de/router_detail.php?FP=FFD2075CC29852C322E1984555CDDFBC6FB1EE80

08:39 < atagar> btw, it's confusing to see a bold field saying "Bad Exit" that defaults to nothing being next to it - it kinda looks like everything is a bad exit

08:39 < atagar> it should just be in the flags section

Cheers! -Damian

Child Tickets

Change History (7)

comment:1 Changed 8 years ago by hellais

This is fixed in 51fab9bf2999a51776a6866b4d5bdc3c41992c91.

Thanks for reporting this bug.

comment:2 Changed 8 years ago by hellais

Resolution: fixed
Status: newclosed

comment:3 Changed 8 years ago by atagar

Resolution: fixed
Status: closedreopened

Sorry to reopen. Now it shows 'BadExit' among the flags (great), but it also still has the bold 'Bad Exit' attribute which, for a bad exit, is saying false...

https://atlas.torproject.org/#details/FFD2075CC29852C322E1984555CDDFBC6FB1EE80

I'm guessing that the attribute is being inverted? Can we drop it since it has the flag?

comment:4 Changed 8 years ago by arma

That url also lists the uptime as "-19 second"

comment:5 Changed 8 years ago by hellais

It should now all be in order. If you think it's a good idea to do so, I can remove the badexit fields from the details page.

Arma: That is a known issue that requires calculating the current time zone of the user accessing Atlas. Since all the calculations are done client side and the restarted time is given in CET we need to adjust for that. This has a separate ticket though: https://trac.torproject.org/projects/tor/ticket/5318

comment:6 Changed 8 years ago by atagar

I can remove the badexit fields from the details page.

Personally I think so. It's very rarely true, and when it is this field is redundant with the flag.

comment:7 Changed 7 years ago by karsten

Resolution: fixed
Status: reopenedclosed

Looks like the Bad Exit field has been removed from the details page in April. Closing.

Note: See TracTickets for help on using tickets.