Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#5594 closed defect (fixed)

or-address missing from dir-spec

Reported by: atagar Owned by:
Priority: Low Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

IPv6 support was added to bridges without its corresponding attribute being added to the directory spec. This is fine, the spec allows for new, unknown fields but ideally this would have been added with the feature.

The snippet to be added is at...
https://gitweb.torproject.org/torspec.git/blob/HEAD:/proposals/186-multiple-orports.txt#l111

I'll upload a patch with some minor modifications to that in a sec.

Child Tickets

Change History (8)

comment:1 Changed 8 years ago by atagar

Status: newneeds_review

comment:2 Changed 8 years ago by nickm

Status: needs_reviewneeds_revision

Thanks! It should probably say that current Tor implementations as of 0.2.3.x don't look at any more than the first alternative address, and don't look at any more than the first port.

Also, I don't know what you mean by,

   An alternative address that can be used instead of ORListenAddress.

Right now, "ORListenAddress" is a term that only makes sense (If I understand right) in the context of the now-deprecated torrc option. It doesn't seem to be a term that the specs use to describe a Tor node's advertised address:orport combination.

comment:3 Changed 8 years ago by atagar

It should probably say that current Tor implementations as of 0.2.3.x don't look at any more than the first alternative address, and don't look at any more than the first port.

Oh, that's definitely good to know. I wasn't planning to preserve the order when parsing but this means that it now matters...

Right now, "ORListenAddress" is a term that only makes sense (If I understand right) in the context of the now-deprecated torrc option. It doesn't seem to be a term that the specs use to describe a Tor node's advertised address:orport combination.

Ahhh, gotcha.

I'll make the changes after work or tomorrow morning.

comment:4 Changed 8 years ago by atagar

Status: needs_revisionneeds_review

Expanded the entry, mind taking another look?
https://gitweb.torproject.org/user/atagar/torspec.git/commitdiff/6285decabe0cfa088e471e070531f5bf1823de7d

What would a descriptor with only an IPv6 address look like? The spec for the router line doesn't mention what an undefined IPv4 address would look like so do all relays, even those with an IPv6 address, require an IPv4 address to function?

One minor gotcha with the current design is that controllers can't determine which or-address entries are accepted or ignored. However, I don't have any use cases that need that so es no importa to me.

comment:5 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-final

comment:6 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; seems ok.

What would a descriptor with only an IPv6 address look like?

I don't think that's specified right now.

comment:7 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:8 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.