Opened 7 years ago

Closed 7 years ago

#5607 closed defect (fixed)

Bridge descriptor sanitizer calculates wrong descriptor digest

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/CollecTor Version:
Severity: Keywords:
Cc: Actual Points: 0
Parent ID: Points:
Reviewer: Sponsor:

Description

When determining SHA-1 hashes of sanitized bridge descriptors in metrics-db we don't include the "router-signature" line. That means we store sanitized bridge descriptors under the wrong file name and reference them from bridge network statuses using the wrong descriptor identifier. The same applies to extra-info digests.

This bug isn't problematic as long as one uses descriptor file names to navigate between network statuses, server descriptors, and extra-info descriptors. But navigating doesn't work anymore when using metrics-lib's getServerDescriptorDigest() or getExtraInfoDigest() methods which calculate the SHA-1 digest correctly. We should fix this bug and sanitize all bridge descriptors again.

Child Tickets

Change History (1)

comment:1 Changed 7 years ago by karsten

Actual Points: 0
Resolution: fixed
Status: newclosed

This issue is now fixed as a by-product of #5608.

Note: See TracTickets for help on using tickets.