Opened 9 years ago

Closed 7 years ago

#5609 closed defect (implemented)

Bridges should announce transport listening addresses to the control port

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: pt tor-bridge
Cc: chiiph, atagar Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Currently the bridge operator has to look at his logs for

Registered server transport 'obfs2' in ''

In the future, we should announce this to the control port so that controllers can pick it up and display it nicely to users.

Child Tickets

#7317closedtorspec: The listening addrport of pluggable transports should be announced on the control portCore Tor/Tor

Change History (8)

comment:1 Changed 8 years ago by nickm

Keywords: tor-bridge added

comment:2 Changed 8 years ago by nickm

Component: Tor BridgeTor

comment:3 Changed 8 years ago by nickm

Status: newneeds_review

whoops; the torspec side of this has a tor branch in state needs-review! better look at it...

comment:4 Changed 8 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

Woops, I misunderstood; that _was_ a torspec branch.

comment:5 Changed 8 years ago by asn

Please see branch bug5609 in

I was not sure which event_format_t to pass to send_control_event. I ended up passing ALL_FORMATS which I'm not sure if it's correct.

comment:6 Changed 8 years ago by asn

Cc: atagar added

(cc'ing atagar so that he knows when this gets merged)

comment:7 Changed 7 years ago by nickm

Status: needs_reviewneeds_revision

event_mask_t is uint32_t.

This patch adds an event "#define EVENT_TRANSPORT_LAUNCHED 0x20". But that doesn't fit in uint32_t.

This makes me wonder whether this patch was actually ever tested. How could that have worked?

I'll widen that mask and add some unit tests.

comment:8 Changed 7 years ago by nickm

Resolution: implemented
Status: needs_revisionclosed

Okay, merged into master.

Note: See TracTickets for help on using tickets.