Opened 7 years ago

Closed 7 years ago

#5632 closed enhancement (implemented)

Make Torperf log timestamps after every 10% of received bytes

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Archived/Torperf Version:
Severity: Keywords:
Cc: robgjansen, sjmurdoch, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Rob suggests to add timestamps between receiving the first byte and completing the request. He suggests timestamps for every completed 10% or 20% of received bytes.

We can easily add timestamps to Torperf's .data files. I wrote a patch to trivsocks-client.c that adds timestamps for 10, 20, ..., 90% of read bytes. I'll push the new branch in a minute when this ticket has a number.

Once this patch is reviewed and merged, we'll want to see how metrics-db and metrics-web can handle the extended .data files. I don't expect any major problems.

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by karsten

Cc: sjmurdoch nickm added
Status: newneeds_review

Steven, Nick, or somebody else who understands C: please review the patch in branch task-5632 in my public repo? Much appreciated!

comment:2 Changed 7 years ago by Sebastian

Looked OK after a quick look. Maybe the while loop wants a comment

comment:3 Changed 7 years ago by karsten

Added a comment. Thanks for the review.

comment:4 Changed 7 years ago by sjmurdoch

Looks good to me too.

comment:5 Changed 7 years ago by karsten

Resolution: implemented
Status: needs_reviewclosed

Thanks for the review!

Merged and deployed on ferrinii and moria. Closing.

Note: See TracTickets for help on using tickets.