Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#5643 closed defect (fixed)

Always check for protocol violations before anything else when handling cells

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In our cell handling functions we sometimes do stuff (like assertions, logging, etc.) before checking that the cell arrived according to the Tor protocol. This leads to bugs.

This is a ticket to fix some of these bugs.

Child Tickets

TicketStatusOwnerSummaryComponent
#5644closedrend_service_introduce() asserts circuit->rend_data before checking for proto violationCore Tor/Tor
#5645closedrend_mid_rendezvous() encodes rendezvous cookie before checking for proto violationCore Tor/Tor
#5646closedMany functions log before checking for proto violationCore Tor/Tor

Change History (3)

comment:1 Changed 8 years ago by nickm

Resolution: fixed
Status: newclosed

comment:2 Changed 7 years ago by nickm

Keywords: tor-client added

comment:3 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.