Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#5729 closed defect (fixed)

Windows improperly sized at TBB startup

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone:
Component: TorBrowserButton Version:
Severity: Keywords: MikePerry201205
Cc: Actual Points: 4
Parent ID: Points: 4
Reviewer: Sponsor:

Description

The old torbutton 50px rounding code is still getting invoked on TBB due to toggle/pref update relics. We should be using the 200x100 rounding instead.

Child Tickets

Attachments (1)

torbutton-1.4.6pre3.xpi (756.2 KB) - added by mikeperry 8 years ago.
This .XPI should fix the window size discrepency between new windows and New Identity

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by mikeperry

Actual Points: 0.5
Points: 0.5
Resolution: fixed
Status: newclosed

This is fixed and will appear in the next torbutton release (1.4.6).

comment:2 Changed 8 years ago by mikeperry

Resolution: fixed
Status: closedreopened

I think this fix is causing weird window resizing on new tab creation...

comment:3 Changed 8 years ago by mikeperry

It was. I fixed the resizing issues in origin/master.

I've also noticed that new windows *still* differ from New Identity windows by 50px, even with these fixes.. The core problem seems related to contentWindow.innerWidth and innerHeight being different during page load due to the gimpy little status bar...

Changed 8 years ago by mikeperry

Attachment: torbutton-1.4.6pre3.xpi added

This .XPI should fix the window size discrepency between new windows and New Identity

comment:4 Changed 8 years ago by mikeperry

Actual Points: 0.54
Points: 0.54
Resolution: fixed
Status: reopenedclosed

I think this is now finally fixed.

comment:5 Changed 8 years ago by cypherpunks

Resolution: fixed
Status: closedreopened

I downloaded Tor Browser 2.2.36-1 for Windows (which still has Torbutton 1.4.5.1)

The browser size starts as 1000x550 and after clicking new identity button, it becomes 1000x600 (when bookmarks toolbar is disabled) or 1000x500 (when boookmarks toolbar is enabled) every time.

After updating to Torbutton 1.4.6 my screen size became 950x550, while testing I've even seen 950x650 once.

I installed 1.4.5.1 back because my fingerprints were unique. But each time I start TBB, it starts toggled to non-Tor each time (which was another issue with the previous Torbutton or Torbrowser, I'm not sure)

So I had to reinstall the browser. I really get bored with the different screen size issues happening with every new versions

comment:6 Changed 8 years ago by cypherpunks

Any progress on this issue?

comment:7 Changed 8 years ago by mikeperry

Resolution: fixed
Status: reopenedclosed
  1. 1.4.5.1 does not have the fix.
  2. If 1.4.6 has weird window sizes "once", or in "some cases", it's not this bug. File a new bug and describe the cases in more detail.
  3. The non-tor initial state issue is a different bug. It doesn't happen for me? File a new bug with details.

comment:8 Changed 8 years ago by cypherpunks

I have Windows 7 32 bit with 1280x800 screen size.

I downloaded the latest Tor Browser.

Now whatever I do (close & open, new identity etc.) the browser window sizes are always 950x600

Is this normal?

comment:9 Changed 8 years ago by mikeperry

We lie about your desktop resolution as if it were always the size of your browser window, since this is less entropy than providing both values. We then set your window size to a set of fixed bins.. They are all supposed to be 200x100 multiples for the inner content window.

I'm not sure why it's 950x600 for you and not 1000x600, though.. What are you using to determine your window size?

What does http://browserspy.dk/screen.php say?

comment:10 Changed 8 years ago by cypherpunks

I were using Panopticlick.

This is a screenshot taken from a fresh 2.2.37-1 install http://img152.imageshack.us/img152/8985/tbb.png

By the way, I'm the guy who reopened this ticket. The browser sizes were 950x550 with 2.2.36-1 + Torbutton 1.4.6

Now they are always 950x600 with the latest browser

comment:11 Changed 8 years ago by mikeperry

Ok, thanks. Yeah, the 50px rounding is not expected. You should be at 1000x600, not 950x600. I created #6146 for that. I think it might be specific to Windows, because I have a 200x100 multiple on Linux right now :/.

Note: See TracTickets for help on using tickets.