Opened 11 years ago

Last modified 3 years ago

#572 closed enhancement (implemented)

fallback-consensus needs autoconf voodoo — at Version 7

Reported by: arma Owned by:
Priority: High Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version: 0.2.0.9-alpha
Severity: Keywords: performance, bootstrap, prop206, tor-client, tor-dos-dirauth
Cc: arma, nickm, ln5 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by Sebastian)

We can put the fallback-consensus in the tarball that results from 'make dist',
but it breaks 'make dist-rpm'.

Right now (0.2.0.12-alpha) it's commented out of src/config/Makefile.am

We need whatever voodoo it takes to let make dist-rpm do its thing too, before
we can reenable it.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (7)

comment:1 Changed 11 years ago by nickm

The right time to put fallback-consensus in is before make dist, not after.

I think that the effects of the desired "voodoo" should be to to have make dist include it if it's present
and nonempty, and to have dist-rpm do the same.

How to achieve this voodoo does not immediately leap out at me; more effort may help.

comment:2 Changed 11 years ago by nickm

The right next steps are to try this and see what breaks and report it exactly.

comment:3 Changed 11 years ago by arma

Ok, I changed src/config/Makefile.am back in r13221. Andrew, can you tell
us exactly how make dist-rpm fails now?

I'm guessing we need to change tor.spec so it knows about this new file
and what it should do with it?

comment:4 Changed 11 years ago by arma

Here's an excerpt from Andrew's make dist-rpm:

Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/tor-0.2.0.17.alpha.dev-tor.0.rh4_6.200801220042-root
error: Installed (but unpackaged) file(s) found:

/usr/share/fallback-consensus

Looks like we don't need autoconf voodoo. We need rpm spec file voodoo.

comment:5 Changed 11 years ago by nickm

This could be as simple as adding a %{_datadir}/fallback-consensus to the %files section of the spec.
But maybe it needs to be made conditional somehow so that the rpm build doesn't fail if the fallback-consensus
is absent. That part, I don't know how to do.

Also, maybe we should be installing this into /usr/share/tor rather than into /usr/share?

comment:6 Changed 11 years ago by nickm

(Fallback consensus logic gives broken results on 0.2.0.x when it's used; postponing till after 0.2.0.x, since it
can't actually be used well here.)

comment:7 Changed 9 years ago by Sebastian

Description: modified (diff)

Do we still want to do fallback consensus things at all?

Note: See TracTickets for help on using tickets.