Opened 7 years ago

Closed 7 years ago

#5766 closed defect (fixed)

no feedback when clicking "Use a New Identity"

Reported by: cypherpunks Owned by: sebb
Priority: Low Milestone:
Component: Archived/Vidalia Version: Vidalia: 0.2.17
Severity: Keywords:
Cc: chiiph, sebb Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

0.2.17 on OSX

There is no feedback whatsoever when clicking the "Use a New Identity" button. The button doesn't "click" indicating anything has happened, there is no message that a circuit has been created, no way to know that the users desire has been carried out and subsequent uses of Tor will come from a different exit.

Child Tickets

Change History (8)

comment:1 Changed 7 years ago by rransom

Component: - Select a componentVidalia
Owner: set to chiiph

comment:2 Changed 7 years ago by chiiph

Priority: normalminor

If you don't have growl or something similar, no, you won't see any visible feedback. This is because of the custom clickable label implementation, which is left out in alpha.

I'm going to leave this open for now, but it is not something that I will focus on since Vidalia alpha will become stable in not so long. I will, on the other hand, accept patches that fix this.

comment:3 Changed 7 years ago by sebb

Cc: chiiph sebb added
Owner: changed from chiiph to sebb
Status: newassigned

I can take care of this. Which one should it be - add some kind of "click" indicator to VCLickLabel class (like different background color between press and release events), or a message in status bar, or both ?

comment:4 Changed 7 years ago by chiiph

The message in the status bar will be tricky, because we are assuming that the user does not have something like growl.

I think just visual feedback from the vclicklabel is enough for this. Have in mind that the alpha already solves this, so the fix for the current stable shouldn't be too time consuming.

comment:5 Changed 7 years ago by sebb

Status: assignedneeds_review

comment:6 Changed 7 years ago by chiiph

Status: needs_reviewneeds_revision

Have you seen the flashing code for VClickLabel? Now that I come to think about it, may be we can merge the idea of having a pressed VClickLabel with a flashing one. What do you think?

I haven't tested your branch yet, in terms of code it looks good.

comment:7 Changed 7 years ago by sebb

Status: needs_revisionneeds_review

you mean something like this ?
https://github.com/sebthestampede/vidalia/commit/7c25ed518387ec31df516af1fe98ef121beb0f56
I think it looks better now with flashing.

comment:8 Changed 7 years ago by chiiph

Resolution: fixed
Status: needs_reviewclosed

Looks good, merged!

It'll be out with 0.2.18. Thanks!

Note: See TracTickets for help on using tickets.