Opened 7 years ago

Closed 7 years ago

#5832 closed defect (fixed)

Indefinite wait if relay no longer exists

Reported by: atagar Owned by: hellais
Priority: High Milestone:
Component: Metrics/Relay Search Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While replacing the metrics and torstatus links on the bad-relays page [1] I noticed that atlas hangs indefinitely when you go to a page for a relay that no longer exists. For instance...
https://atlas.torproject.org/#details/FFD2075CC29852C322E1984555CDDFBC6FB1EE80

The animated gif gives the impression that it's still doing something, but that's probably a lie. We should display something saying that the relay no longer exists. Ideally we'd tell them when the relay was last around and a snapshot of its state, but if that isn't possible then getting whatever assurance atlas can provide ('that relay has been offline for the last X days') would still be preferable to what it has now.

[1] https://trac.torproject.org/projects/tor/wiki/doc/badRelays

Child Tickets

Change History (6)

comment:1 Changed 7 years ago by atagar

Summary: Indefinite wait in relay no longer existsIndefinite wait if relay no longer exists

Drats, typo

comment:2 Changed 7 years ago by karsten

Atlas wouldn't be able to tell when the relay was last seen online and what its state was. It can only say that it wasn't online in the last 7 days.

comment:3 Changed 7 years ago by atagar

Atlas wouldn't be able to tell when the relay was last seen online and what its state was.

Kinda thought that was the case.

It can only say that it wasn't online in the last 7 days.

Great. That sort of information is just what the notice page should say.

Yesterday I ran into this same issue for HumaniTOR which was available on atlas an hour before and is online now, so I was under the impression that transient relay outages also cause Atlas to hang. Maybe I'm wrong on this...

comment:4 Changed 7 years ago by karsten

Note that you can always access Onionoo directly using your browser to see whether Onionoo or Atlas is to blame, e.g., https://onionoo.torproject.org/details/search/HumaniTOR. If Onionoo doesn't know about a relay it would display something like this: https://onionoo.torproject.org/details/search/doesnotexist (why am I waiting for someone to call their relay doesnotexist...). See https://onionoo.torproject.org/ for the full protocol.

comment:5 Changed 7 years ago by karsten

Status: newneeds_review

Please review branch task-5832 in my public repository. Thanks!

comment:6 Changed 7 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Merged and deployed. Closing.

Note: See TracTickets for help on using tickets.