Opened 8 years ago

Closed 7 years ago

#5852 closed defect (fixed)

WebResource.getBridgeRequestAnswer() is unhappy about IPv6 addresses

Reported by: ln5 Owned by: aagbsn
Priority: Medium Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Keywords:
Cc: aagbsn Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Logs on ponticum fill up with warnings about badly formed
X-Forwarded-For headers. Most (all?) of them appear to be IPv6
addresses.

Bridges.is_valid_ip() recognizes IPv4 addresses only.

I don't know if extending is_valid_ip() is the right thing to do but
it might. I haven't looked into other usage of it.

Child Tickets

Change History (2)

comment:1 Changed 8 years ago by aagbsn

Owner: set to aagbsn
Status: newaccepted

This is occurring because the X-Forwarded-For header contains an ipv6 address, and the currently deployed BridgeDB does not expect or understand IPv6 addresses.

The patch(es) to fix this lives in my bridgedb repository, in the 4297-ipv6-bridges-* branches.

is_valid_ip() is extended as well as the area mapper for ipv6 clients (see Dist.py uniformMap()).

comment:2 Changed 7 years ago by aagbsn

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.